Path change affects Redux Actions about jupyter-ui HOT 17 CLOSED

By the way, it seems that the latest release of the npm website is displaying strange code on its main page. I apologize for mentioning it here, as it may not be significant enough to warrant a new issue report.

from jupyter-ui.

Hey @echarles, thank you so much for your help! I'm happy to report that everything is working perfectly now with Yarn. It's interesting to know that npm was causing issues with the library. I really appreciate all your effort and responsiveness. The remaining CSS issue with the matplotlib widget is minor, so not a big problem. I will close this issue now that everything is solved. Thanks once again for your assistance!

from jupyter-ui.

Thx a lot for reporting @BrandonEscamilla I will look at this tomorrow.

Quick question: with 0.6.4, are the redux actions broken on path change?

from jupyter-ui.

Hi @echarles, I tested version 0.6.4 and encountered the same issue.

from jupyter-ui.

I have released 0.7.0 which fixed this. Can you confirm it work for you?

from jupyter-ui.

Hey @echarles, thank you for taking the time to fix this one, I am just testing and it seems the redux actions works as expected now, with an exception, it seems the cells can't run code now. I attach a gif of the behavior.

P.S. Happening before and after path change.

from jupyter-ui.

Run is working for me. Can you double-check/confirm it is an issue on your env? Any error message in the devtools console?

I will push a new release based on your feedback (on this on other issues) so those debugging notes disapear from npm :) Thx again for reporting 👍

from jupyter-ui.

Oh interesting, it's weird, I can only see one error for both Notebook and Jupyter (attached below), but apart from that I can't see anything else. Also, I already re-install the package, and tried to make it work in different ways unsuccessfully. Any idea? I am testing in an scratch project using next.js 13, so there is nothing else only the jupyter component.

app-index.js:31 Warning: Notebook: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

from jupyter-ui.

Will try in next.js, what I was doing was outside of next. Maybe useful that you confirm if it is working or not without next.js.

from jupyter-ui.

Just tried with next and it is working fine on my env. I will create a separated next.js application tomorrow and will try to deploy with vercel to see what it gives. I will also push my code tomorrow.

from jupyter-ui.

Hi @echarles, I've thoroughly tested the new version of Jupyter-React and can confirm that the issue is not with my environment. I've tried various troubleshooting steps such as reinstalling, adjusting my Node versions, and creating new projects with Create React App (CRA) and Next.js, but I'm still unable to run the cells. My guess is that there might be a relative path that works in your development environment but doesn't work in other environments. Please let me know your thoughts or if there's anything else I can try. Additionally, I've also tried reverting to version 0.6.5 in all the examples I ran, and it seems to work as expected. Thanks in advance!

from jupyter-ui.

Yes, I have a fix for that on next.js. Pushing it now.

from jupyter-ui.

I have a separated project on https://github.com/echarles/jupyter-nextjs-example. I am documenting how to configure next.js and also deploying it on vercel. Would be great that you clone and confirm it is working (you have to use yarn)

from jupyter-ui.

Thanks @echarles, I am testing the repo and it's not working i am getting the following error:

I guess it's server related?

from jupyter-ui.

I have hit that error a few time depending on how I was buildling (yarn, npm...) and also double rendering, therefor I had to disable react strict mode.

const nextConfig = {
   reactStrictMode: false,
}

Since then I was not hitting that error anymore...

from jupyter-ui.

Ok, I tried your prod version of Next.js at https://jupyter-nextjs-example.vercel.app/ and it seems it's not working. For me, it's not displaying the notebook and showing this error:

I am also testing the Next.js repository you shared, and it's not working locally with Yarn v3 and reactStrictMode set to false. I'm getting the following error when using the datalayer Jupyter server:

If I use my own Jupyter server, I'm encountering a different error:

Is there something I am missing, should I try something else? Thanks in advance!

from jupyter-ui.

@BrandonEscamilla Thx you so much for your willingness to help and test.

🎉 🎉

https://jupyter-nextjs-example.vercel.app is now working. You will need jupyter-react 0.7.4 and check the requirements on https://jupyter-ui.datalayer.tech/docs/examples/next-js

There is still a small CSS glitch for the jupyter-matpltlib widget (on my env), but otherwise the kernel is kept on reload and the path change is working for me.

Curious to know if it works for you

from jupyter-ui.