[core] PGBouncer stats for version latest fails due to extra columns about integrations-core HOT 7 CLOSED

I note that you're using psycopg2 for access to pgbouncer.

Instead of trying to extract data positionally from the SHOW commands, I'd recommend you switch to using the psycopg2 Dict mode that allows you to reference the row columns by name, vs. trying to manage positional integrity:
http://initd.org/psycopg/docs/extras.html
psycopg2.connect(dsn, cursor_factory=DictCursor)

from integrations-core.

Hi @Verhaeg, thanks for reporting this. Indeed they recently added a column in pgbouncer/pgbouncer#212 though it's not been released yet. The check is working with pgbouncer version 1.7.2.
I'll add this to our backlog and keep the issue open to track the work !

from integrations-core.

PgBouncer version 1.8.1 is out, and it looks like there are some new/renamed columns (at least for SHOW STATS) there as well:

pgbouncer=# SHOW POOLS;
   database   |   user    | cl_active | cl_waiting | sv_active | sv_idle | sv_used | sv_tested | sv_login | maxwait | maxwait_us |  pool_mode  
--------------+-----------+-----------+------------+-----------+---------+---------+-----------+----------+---------+------------+-------------
 datadog      | datadog   |         0 |          0 |         0 |       0 |       0 |         0 |        0 |       0 |          0 | transaction

pgbouncer=# SHOW STATS;
   database   | total_xact_count | total_query_count | total_received | total_sent | total_xact_time | total_query_time | total_wait_time | avg_xact_count | avg_query_count | avg_recv | avg_sent | avg_xact_time | avg_query_time | avg_wait_time 
--------------+------------------+-------------------+----------------+------------+-----------------+------------------+-----------------+----------------+-----------------+----------+----------+---------------+----------------+---------------
 datadog      |                0 |                 0 |              0 |          0 |               0 |                0 |               0 |              0 |               0 |        0 |        0 |             0 |              0 |             0

For this new version PgBouncer check fails with the same error:

            ...
            assert len(row) == len(cols) + len(desc)
        AssertionError

from integrations-core.

Furthermore, there are a couple open PRs in the pgbouncer repo that add even more stats:

pgbouncer/pgbouncer#168
pgbouncer/pgbouncer#72

It feels like we might need a more robust way of reporting the metrics that we recognize, and maybe just warning when we see new or unfamiliar statistics

from integrations-core.

Is this fixed by #1016?

from integrations-core.

FWIW I just installed the latest version of the DD agent (5.22.0) and I can now use the pgbouncer integration.

from integrations-core.

Seems to be fixed, closing...

from integrations-core.