Git Product home page Git Product logo

Comments (7)

MattJeanes avatar MattJeanes commented on August 22, 2024 1

No worries, I've just tested it now and it's all good. Thank you!

from helm-charts.

MattJeanes avatar MattJeanes commented on August 22, 2024

Okay update after a little more investigation, yeah it's definitely because we're installing it twice as dependencies - it looks like the way the config map is named is not using the {{ template "datadog.fullname" . }} underneath like other config maps such as the install_info-configmap.yaml which means that it doesn't use the nameOverride that we have specified, and the two names conflict causing the install error.

from helm-charts.

CharlyF avatar CharlyF commented on August 22, 2024

Hi @MattJeanes - Thanks for reaching out and sorry about this. We are fixing this.

from helm-charts.

MattJeanes avatar MattJeanes commented on August 22, 2024

Thank you! No problem, it didn't cause us too much trouble we have just rolled back to the previous version for now :)

from helm-charts.

CharlyF avatar CharlyF commented on August 22, 2024

@MattJeanes could you give the new chart version a go to verify if it solves your issue?

from helm-charts.

MattJeanes avatar MattJeanes commented on August 22, 2024

Hi @CharlyF, unfortunately it is not working, it appears this is because these lines in the cluster-agent-deployment.yaml haven't been updated to match:

helm-charts/charts/datadog/templates/cluster-agent-deployment.yaml

Lines 331 to 345 in eafa471

- name: DD_INSTRUMENTATION_INSTALL_TIME
valueFrom:
configMapKeyRef:
name: {{ .Release.Name }}-kpi-telemetry-configmap
key: install_time
- name: DD_INSTRUMENTATION_INSTALL_ID
valueFrom:
configMapKeyRef:
name: {{ .Release.Name }}-kpi-telemetry-configmap
key: install_id
- name: DD_INSTRUMENTATION_INSTALL_TYPE
valueFrom:
configMapKeyRef:
name: {{ .Release.Name }}-kpi-telemetry-configmap
key: install_type

I also noticed that the naming pattern seems different to the other config map here:

helm-charts/charts/datadog/templates/install_info-configmap.yaml

Line 4 in cb13eed

name: {{ include "agents-install-info-configmap-name" . }}

helm-charts/charts/datadog/templates/_helpers.tpl

Lines 544 to 550 in cb13eed

{{- define "agents-install-info-configmap-name" -}}
{{- if .Values.providers.gke.autopilot -}}
datadog-agent-installinfo
{{- else -}}
{{ template "datadog.fullname" . }}-installinfo
{{- end -}}
{{- end -}}

It's your Helm chart of course so as long as it works I don't mind, but may be good to keep things consistent 🙂

from helm-charts.

CharlyF avatar CharlyF commented on August 22, 2024

good catch - we pulled the trigger a bit too quickly. We just merged a fix, hopefully this time is the right one!

from helm-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.