Comments (5)
Also noticed that the logs that are being processed (log lines with content duration...
) have http.status_code: 200
or http.status_code: 500
, but the official log status in DD is INFO
. For the Ruby Integration Pipeline, log status is mapped to the attribute level
.
Can logging in the service include categorizing http.status_code
into a level
attribute? Categories like the ones below or whatever would make sense for the app.
Category | Level |
---|---|
http.status_code:[200 TO 299] | ok |
http.status_code:[300 TO 399] | notice |
http.status_code:[400 TO 499] | warning |
http.status_code:[500 TO 599] | error |
from ecommerce-workshop.
After more than a few rounds of local testing, I think lograge as we prescribe does not cover all cases for logging and thus we will probably want to update the docs to cover this particular case. Lograge is built around covering request logs, but doesn't cover caching or SQL queries for example which you point to up there. Even our own advice by default does not cover severity either so I will try to make some quick patches for now, but figure out a longer term solution with our ruby folks to see if there is a better out of the box method here.
from ecommerce-workshop.
I am now exploring using semantic logger to replace lograge. If it works, I will probably discuss with the docs and logs teams to see if we can shift our recommendations to that solution since it is more actively maintained and might have a better out of the box experience.
from ecommerce-workshop.
This is the furthest I can reasonably go in cutting down the logging noise right now
Once we can ship the default logs changes internally, I can do a fresh PR to switch us to semantic logger which will help a lot for formatting all the log messages correctly and work out of the box better.
from ecommerce-workshop.
This is now resolved by #80
from ecommerce-workshop.
Related Issues (20)
- Discount codes should work HOT 3
- Tracer contexts are not working in logs
- update logging configuration in store-frontend so that Ruby intergration pipeline can be used as is HOT 5
- ARM build support
- discounts-service or discounts in the k8s yaml files HOT 1
- RUM config `env` value should come from environment var HOT 1
- Auto-generate RUM data HOT 5
- Problems building store-frontend-broken-no-instrumentation HOT 1
- Expose and increase Shopping Cart functionality
- Getting NoMethodError after deployment using generic-k8s method HOT 1
- RUM not working HOT 2
- Hardcoded agent on localhost in advertisements and discounts HOT 3
- Make ads and discounts services XHR compatible HOT 1
- Add to cart does not work in embedded synthetic browser test recorder HOT 2
- Update ddtrace in discounts and ads services to latest
- Update ddtrace Gem in storefornt to lates tversion
- Unable to export profile: ddtrace.profiling.exporter.ExportError: HTTP Error 403
- ECS example: Error loading the 'postgresql' Active Record adapter HOT 1
- Unable to deploy storedog Application HOT 4
- Unable to deploy Store Fronted Application
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ecommerce-workshop.