Sidekiq in development doesn't respect initializer config about dd-trace-rb HOT 5 CLOSED

More specifically, this seems to be the problem:

Because redis is patched and starts writing spans well before anything in config/initializers/* is loaded there are already recorded spans attempting to be sent to the datadog agent before the tracer is disabled in development.

from dd-trace-rb.

The only way to prevent this seems to be preventing ddtrace from being required at all outside production by using gem "ddtrace", group: "production" in the Gemfile. We'd prefer to keep it loaded in all environments for parity with production and so we can add application instrumentation.

from dd-trace-rb.

Thank you for reporting that @sj26 ! we'll be sure that the next release doesn't have such kind of issues.

from dd-trace-rb.

#86 should remove the root cause about Redis sending traces despite defined settings. A configuration like:

Rails.configuration.datadog_trace =
  {
    # may depend by your conditional env
    enabled: false,
    # these may be 'true' to keep parity with your production
    auto_instrument: true,
    auto_instrument_redis: true
  }

ensures that:

• Rails is auto-instrumented after bundler requires ddtrace
• Redis is auto-instrumented after bundler requires ddtrace
• if redis-rails is used and Redis is auto-instrumented, redis-rails will use the traced Redis client
• disabling the tracer means that traces will not be reported but the code will still be instrumented like in your production environment.

from dd-trace-rb.

Fixed with #86 . Redis auto-instrumentation (available after any kind of require 'ddtrace') honors the Rails initializer. So if the tracer is disabled, Redis is instrumented after so that no traces are sent from the transport layer (but traces are still generated and Redis is still instrumented). This plays well with Rake scripts and Sidekiq (in environments where the tracer is not enabled).

If you spot another problem, feel free to re-open the issue or to create a new one! The next release will be available by the end of the week and it includes a better Sidekiq support!

from dd-trace-rb.