Git Product home page Git Product logo

Comments (3)

delner avatar delner commented on August 22, 2024

Hey @Ferdy89, thanks for bringing this up! Sounds like a good suggestion; we'll need to reconcile the Sidekiq error handler with how the Sidekiq tracer works. I'd be happy to take a deeper look at this and get back to you.

from dd-trace-rb.

delner avatar delner commented on August 22, 2024

Took a look into reproducing this issue, and it does indeed flag Sidekiq jobs that are aborted by Sidekiq::Shutdown exceptions as errors.

Good news is that if you'd like these not to report as errors, you can using the "Processing Pipeline" feature, which allows you to modify or filter out spans to customize your application's needs.

Here's a snippet I whipped up that will remove the error status from Sidekiq jobs that fail via shutdown. It preserves the back traces and exception type, but the UI will render their status as "Ok" instead of "Error". Just add it to your Datadog initializer file:

# Unflag Sidekiq jobs that fail with Sidekiq::Shutdown errors
Datadog::Pipeline.before_flush(
  Datadog::Pipeline::SpanProcessor.new do |span|
    if span.name == 'sidekiq.job' && span.get_tag(Datadog::Ext::Errors::TYPE) == 'Sidekiq::Shutdown'
      span.status = 0
    end
  end
)

Wanna give this a shot and let me know if this helps?

from dd-trace-rb.

delner avatar delner commented on August 22, 2024

Closing this given the lack of activity. Please feel free to respond here if you'd like to revisit this issue.

from dd-trace-rb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.