Comments (5)
The cirumstance where the 404s are not useful to be grouped together is because applications may implement generic routes with a different permission scheme. i.e. if I am seeing a huge number of 404s on the url pattern /foo/:id/bar/:id
, I want to see the spans with 404s grouped under the same resource name /foo/:id/bar/:id
instead of a catch-all 404
.
from dd-trace-java.
@rymndhng Is this instrumentation for a server? If so how would you know which resource to associate the 404 with?
For example, if you had two endpoints /my/service
and /other/service
, where would you expect a request /a/bad/request
to appear?
from dd-trace-java.
@realark I think I see where you're coming from. In the case where there is no tag resource.name
set, it would be valuable to set resource.name
to 404.
The current implementation always sets the resource.name
to 404 when the response status is 404. I think it would be more reasonable to set the resource.name
if it is not already set. This would users to distinguish between 404s from mismatched routes v.s. 404s returned by your application.
from dd-trace-java.
@rymndhng can you explain the circumstance where the 404 being returned by the application is useful to not group together?
from dd-trace-java.
Resolved with #1152
from dd-trace-java.
Related Issues (20)
- java.lang.UnsupportedOperationException from SnsInterceptor when trying to publish HOT 2
- Use hikari pool name as service name
- Graphql-java 22 support HOT 3
- Missing @http.status_code in Play HOT 3
- Dynamic Instrumentation fails to start when tracing is configured to use UDS HOT 5
- java.lang.IllegalStateException: Shutdown in progress in dd-ci-git-data-uploader HOT 1
- Google PubSub DD service name is hardcoded
- Latest java agent 1.35.1 and .2 breaks APM tracing HOT 7
- Kotlin coroutine instrumentation missing spans in trace
- Datadog Trace Span Issue with MySQL Batch Inserts using MySQL Connector/J
- Akka scheduler tasks should create spans
- Unable to capture gRPC list field in dynamic instrumentation HOT 1
- Datadog Trace Span Issue with Apache HttpClient5 HOT 3
- How to change DataDog java agent trace api version to V0.5 HOT 2
- Quarkus 3.12.1 + Kafka + DD + Native = BOOM HOT 23
- HTTP 400 Bad Request being marked as a false positive server error in Keycloak HOT 5
- Graphql-java 22 Support Still Not Working HOT 5
- Outgoing http requests are not instrumented with datadog tracer - Spring Boot / RestClient / Eclipse Jetty Client 12.0.5 HOT 4
- DD_TRACE_HEADER_BAGGAGE environment variable is not being honoured HOT 2
- Cannot invoke "datadog.trace.civisibility.config.JvmInfo.getName()" because "jvmInfo" is null HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dd-trace-java.