Make visibility of auto-approval toggle configurable based on confidentiality about dataall HOT 4 OPEN

Check the video for a feature demo.

from dataall.

Note:
Additionally, on the backend we have code to validate “auto_approval_for_confidentiality_level” value for Secret confidentiality. This is to ensure that if someone uses a proxy or curl command and sets the value auto_approval_for_confidentiality_level=true for the confidentiality level, in the backend side we still wont run the auto-approval workflow.

Would recommend anyone using this feature to use the following code to manage the backend side. I have not included it in the PR since this is only needed if one of the auto_approval_for_confidentiality_level is set to false. We keep all of them true by default.

Change in share_object_service.py https://github.com/data-dot-all/dataall/blob/main/backend/dataall/modules/dataset_sharing/services/share_object_service.py#L288

if dataset.autoApprovalEnabled: --> if dataset.autoApprovalEnabled and ConfidentialityClassification.get_confidentiality_level( dataset.confidentiality) != ConfidentialityClassification.Secret.value:

• Instead of using ConfidentialityClassification.Secret.value use whatever confidentiality you want to disable.

from dataall.

Pending a follow up PR for backend changes before closing this issue

from dataall.

Hi @anushka-singh @TejasRGitHub - following up on this issue, I believe there may still be some work on the backend for this issue to handle input validation / not allowing autoapproval for the specified confidentialities in config.json

Is this to be picked up by you all? / Would this be a part of #1261 and can close this issue?

from dataall.