Git Product home page Git Product logo

Comments (7)

jrbourbeau avatar jrbourbeau commented on August 17, 2024 3

Yeah, I like the idea of canonical URLs as well. That said, I think updating some of the notebooks here to point to https://docs.dask.org/en/latest/_images/dask_horizontal.svg is a reasonable short-term fix

from dask-tutorial.

scharlottej13 avatar scharlottej13 commented on August 17, 2024 1

Thanks for catching this @pentschev! And thanks @jrbourbeau for the investigation! I'm happy to make these updates.

always point to the https://docs.dask.org/en/latest/_images/dask_horizontal.svg. I'm inclined to go with the second option -- though open to thoughts from others.

I agree this option seems better.

from dask-tutorial.

jrbourbeau avatar jrbourbeau commented on August 17, 2024

Good catch @pentschev. It looks like some notebooks are pointing to https://docs.dask.org/en/latest/_images/dask_horizontal.svg (which uses the new logo) while others are pointing to this image in the dask-tutorial repo https://github.com/dask/dask-tutorial/blob/0f213fc240ee2c788dd1230d0f23d72d9e296760/images/dask_horizontal.svg.

We could update the image in this repo to be the new logo, or remove the image from this repo altogether and always point to the https://docs.dask.org/en/latest/_images/dask_horizontal.svg. I'm inclined to go with the second option -- though open to thoughts from others.

@scharlottej13 do you have bandwidth to make these updates?

from dask-tutorial.

jacobtomlinson avatar jacobtomlinson commented on August 17, 2024

We should have one canonical source of truth for the logo. In some places I noticed that I've pointed things at the GitHub avatar for the small logo, so they all got updated when we replaced that, but this still isn't ideal because it isn't obvious.

I think we should aim to document on https://dask.org/brand-guide what the URLs for the logos are. I think right now it just let's you download a zip which is fine but not ideal.

I also wonder if we could choose some neat canonical URLs like https://dask.org/logo/dask_horizonal.svg and point everything there. We could use the docs link for this like you suggested, but I'd been keen to try and keep everything related to branding in WebFlow if we can.

Right now it looks like the main logo on dask.org points to https://assets.website-files.com/627ac9e2b71e64a6a0b76027/627adb72f21c6b4063e05b51_dask-header-logo.svg which seems to be some WebFlow internal CDN implementation detail leaking out. Once we get better access to WebFlow I'm keen to see if we can do better than this.

from dask-tutorial.

jsignell avatar jsignell commented on August 17, 2024

I really like the idea of using canonical URLs.

from dask-tutorial.

jsignell avatar jsignell commented on August 17, 2024

Closed by #240

from dask-tutorial.

pentschev avatar pentschev commented on August 17, 2024

The image link seems to be broken in https://tutorial.dask.org/00_overview.html (others are correct), it seems like it should have the full URL, rather than a relative path. Also in https://tutorial.dask.org/Homework.html there's no logo, but I'm not sure whether that's intended or not.

from dask-tutorial.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.