[BUG] Not all follows retrieved about mangadesk HOT 6 CLOSED

ngl. I never expected anyone to have this many follows.

from mangadesk.

api seems to have problems with offset values (there seems to be an edge case where you cant get just the last followed manga).

i think this will take awhile to fix

from mangadesk.

@scott-tancock i will be releasing a test build addressing this issue soon. will also have an added feature for pagination (loading 800+ follows on a single page would probably burn down someone's PC and their home).

from mangadesk.

You may test out the alpha release here: https://github.com/darylhjd/mangadesk/releases/tag/v0.2-alpha

from mangadesk.

Seems to be working to me. Fetches all 812 Manga, and each item can be accessed as normal. Few odd quirks with the
interaction:

• When loading a page of follows, the current selection jumps around a bit. It gets set back to the previous location once all 100 follows are loaded, but it looks a tad weird. Probably just a quirk of tview and not possible to fix.
• If moving between follows pages quickly (press tab again before current page has finished loading), the cursor ends up moving down the page somewhat. This is probably a race condition between the page load and setting the cursor back to the top after the previous page load. This really isn't a major issue, just a quirk.
• The combination of tab / ctrl+b is rather strange. It would be great to change it to a common combination such as ctrl+f / ctrl+b or tab / shift-tab.
• Maybe set the final page of follows to show the total number of follows in the top status bar. e.g. current: "Page 9 (801-900)", suggested: "Page 9 (801-812)".

^ Those are all just minor matters. If no-one else is having an issue with this patch, the issue can be closed. Pretty impressive how fast you fixed this.

from mangadesk.

1st point:

• its tview.

2nd point:

• yea it just starts updating the table through all the pages lol, but the end result should still be the last page you tabbed/ctrlb to. i am thinking of a solution to pass context through goroutines to stop previous updates but i havent figured it out yet.

3rd point:

• key space is getting a little too crowded now. i wanted backtab (shift + tab) but it doesnt work on my machine and so safe to say i wont be using it.

4th point:

• ok good point. only excuse at this point is because i was lazy to check total entries :>

from mangadesk.