ExpressionBuilder should be assignable to StatementBuilder about code_builder HOT 4 CLOSED

Sorry, let me clarify, you'd like to do:

var method = new MethodBuilder.returnVoid('main');
var statement = new StatementBuilder()
  ..addExpression(const LiteralString('blah').invoke('substring', positional: [
    const LiteralInt(1)
  ]));
method.addStatement(statement);

Is that right? Or do you specifically mean that maybe we should allow:

// Option 1
new StatementBuilder.fromExpression(...)

// Option 2
expression.toStatement()

from code_builder.

The end result would be like in the first example, but the way I was thinking about is that there wouldn't be any special API to add an expression. Instead, an expression is a special case of a statement. IOW, ExpressionBuilder extends StatementBuilder so you can pass an ExpressionBuilder to addExpression or anything else that takes a StatementBuilder.

In Dart you can use any expression as a statement, e.g.:

// A valid Dart program
void main() {
  5;
  null;
  'hello';
  []..add(4);
}

from code_builder.

Or, maybe we should do what the analyzer is doing :)

from code_builder.

In that case, option 2 looks great.

from code_builder.