Comments (3)
Turns out we already support this. The types did not suggest so (which was fixed in 04dbe4e) but the code was all good (since in TS, debugSessionId as string
doesn't do anything, and allows the null/undefined through!).
Just needs some testing from DevTools.
from dart-code.
I tested this by forcing a null debug session ID in DevTools sidebar:
Then launched two debug sessions and tried to open Inspector from the DevTools sidebar. It prompted for a debug session as expected:
This is because it goes through the usual code path for launching DevTools pages and that checks whether the target page requires a debug session and if one wasn't provided will prompt.
@kenzieschmoll the DevTools API classes already allow for null here too, so this is implementable today. If you pull the DevTools buttons up to the top level and pass null
here, it'll do what we want.
from dart-code.
Actually, that's not the full story... The check for whether we need require a debug session / VM Service looks like this:
const page = devToolsPages.find((p) => p.id === pageId);
const requiresVmService = page && !page.isStaticTool;
So if we don't recognise the page
, we'll assume a session is not required. This will be problematic for extensions (which Dart-Code doesn't know about).
So we need an API change to allow DevTools to dictate whether we prompt for a session or if one is not necessary (because it's a static tool). I'll look at adding something to support this distinction.
from dart-code.
Related Issues (20)
- Support try/catch/finally fold
- "Don't show again" option for "Project contains issues that can be fixed by dart fix" prompt does not persist HOT 3
- Not able to "Go to Type Definition" in `for-in` loop variable HOT 1
- Variable hover should show the origin of the given type HOT 1
- Update syntax highlighting for digit separators
- Unable to open static DevTools extensions on current Flutter beta HOT 5
- Unable to copy using buttons in DevTools HOT 5
- Failure to read files from workspace roots via DTD on Windows HOT 5
- Breakpoint not hit on web after a hot reload in latest stable HOT 10
- Go to file keyboard binding doesn't work HOT 2
- Add a setting to completely disable using `pub` (no prompts, no automatic running, no commands/toolbar buttons) HOT 4
- ui guide not working in android studio HOT 1
- Possibility to filter internal debug log HOT 1
- Flutter daemon left orphaned after IDE was closed HOT 8
- Remove Widget also in list Widgets HOT 3
- Move to file not moving to existing file even after agreeing to replace it HOT 23
- VideoPlayerController Does not send headers when Ran from Web on a request requiring CORS HOT 1
- debugging isolates seems flakey HOT 6
- CTRL + Click `part of 'file.dart';` directive doesn't work without `part` directive HOT 4
- Refine: make the running panic stops at user code zone but not SDK/system code zone HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dart-code.