some suggestions about base85 HOT 6 CLOSED

@darkwyrm can you pls release the fixed version?
Sure. I had forgotten about this, so I appreciate the request. I still don't completely understand everything in the code, but I understand enough to be comfortable releasing. v1.2.1 is on crates.io and in GitLab/GitHub as commit edf5f5a.

from base85.

I didn't remember any API changes, hence the small version bump. I've made the requested version correction.

from base85.

That is very useful. The current code is more or less a straight port from the Go version I wrote when I was first learning it. You've definitely given me some things I haven't seen before to process and learn. Once I understand the stuff I don't recognize I'll get to merging it in. Thanks so much for the suggestions!

from base85.

Optimizations merged (with very slight modification) in commit 4209ac1

from base85.

@darkwyrm can you pls release the fixed version?

from base85.

Thank you very much, but there is one problem though: the new version is API breaking, and you did not make a semver-compatible version change (you updated only minor version and not major). This broke downstream compilation of all released projects which used your crate:

   |
86 |         let data = base85::decode(s).ok_or_else(|| {
   |                    ------------------^^^^^^^^^^ help: there is a method with a similar name: `or_else`

Can you please cargo yank --version 1.2.1 and re-publish the new version as 2.0.0?

from base85.