Comments (27)
I don't get the issue. So export is fine, the issue is only visible in darkroom? Then we need the
-d pipe
output while opening in dr. Maybe also--dump-pipe diffuse
. Can you see the issue with 'toggle high quality processing' = on ?
For me (OP) the problem is in the export not in the visualization in dt. Also, please find attached the two log files obtained with with "darktable -d opencl -d pipe" (and, yes, "local contrast" of the DoS module was enabled).
thanks for looking into this
new_log_fuji_raf.log
new_log_ricoh_dng.txt
from darktable.
Can you share the RAWs + XMPs so I can try to reproduce on my Intel Mac.
from darktable.
Well, it seems that I can't just attach raw files (or even their xmp) here...
from darktable.
you can put them on a file sharing service and provide the url here.
from darktable.
could you suggest one? I normally use WeTransfer, but the link is sent automatically to an email address
from darktable.
why don't you have the link sent to you and then copy/post it here
there is also google drive and many others. google can provide a list.
from darktable.
We would likely want a first check, are issues related to CL compiler optimizing flag?
from darktable.
Ok, so here's a WeTransfer link to download the files:
from darktable.
@gpagnon could you open the darktablerc file, locate the line with '-cl-fast-relaxed-math' and remove that string. Then clear all compiled kernels and restart darktable? (That would mean you don't have the opencl compiler doing some maths optimizations) We had some problems with intel devices some time ago on linux ...
from darktable.
When working with these two files darktable crashes on line 1993 in src/common/darktable.c
darktable/src/common/darktable.c
Lines 1985 to 1996 in e458f34
from darktable.
from darktable.
- I tried here with current master on fedore both with gcc and clang compiled and can't reproduce.
- @gpagnon I looked at your opencl enabled logfiles. In both logs i do not see the diffuse module being processed!. Could you repeat with
darktable -d opencl -d pipe
, export the files that don't work for you, close darktable and post the logfile? - @zisoft could you do that too?
from darktable.
Images exported with the settings described.
First image with log:
dt_1.txt
Second image:
dt_2.txt
from darktable.
with some files (I saw it on a Ricoh GR's DNG file) the exported jpg is just an unrecognizable set of stripes
This is the lighttable full screen preview of image 1:
![Bildschirmfoto 2024-03-06 um 20 58 49](https://private-user-images.githubusercontent.com/4083281/310645943-1dd92349-6743-4644-b8b6-e1505cb814e0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc5NDc4NTYsIm5iZiI6MTcxNzk0NzU1NiwicGF0aCI6Ii80MDgzMjgxLzMxMDY0NTk0My0xZGQ5MjM0OS02NzQzLTQ2NDQtYjhiNi1lMTUwNWNiODE0ZTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MDlUMTUzOTE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGRkYjQ4NzMxYzMwOTg4YjUzZTRlYjZlZDQ1NzVmZGViMDkxOGE5MDc5Zjc1YmEwODc4MjZlZDk0YzBlM2E3NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.1-Nib2P7tbAExnNRD8cyT2yLwdoSeakjno4ifoLuC_g)
from darktable.
I don't get the issue. So export is fine, the issue is only visible in darkroom? Then we need the -d pipe
output while opening in dr. Maybe also --dump-pipe diffuse
. Can you see the issue with 'toggle high quality processing' = on ?
from darktable.
The issue with the stripes is only in lighttable full preview (F).
Opening in darkroom gives this:
![Bildschirmfoto 2024-03-06 um 21 46 38](https://private-user-images.githubusercontent.com/4083281/310659143-0a9adaf7-36cf-437d-925a-166d2c623ecb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc5NDc4NTYsIm5iZiI6MTcxNzk0NzU1NiwicGF0aCI6Ii80MDgzMjgxLzMxMDY1OTE0My0wYTlhZGFmNy0zNmNmLTQzN2QtOTI1YS0xNjZkMmM2MjNlY2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MDlUMTUzOTE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGEyNTZmOWNiYmEzMTI2MGM4ODQxZDRkN2Y3OGU4MzQyOTJhOTkwNWIxYThhYTAzODQyMmJmM2M2MzU4YTUyYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.pV0OBoAGm6b2shB0eXhotcKUZyuMLnLwhnr7flbXDMM)
And switching 'high quality processing' on:
![Bildschirmfoto 2024-03-06 um 21 47 05](https://private-user-images.githubusercontent.com/4083281/310659345-d8e7e04e-3209-48d5-ae6c-db848fdb74ca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc5NDc4NTYsIm5iZiI6MTcxNzk0NzU1NiwicGF0aCI6Ii80MDgzMjgxLzMxMDY1OTM0NS1kOGU3ZTA0ZS0zMjA5LTQ4ZDUtYWU2Yy1kYjg0OGZkYjc0Y2EucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MDlUMTUzOTE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTg1ZGFiZGQ0NjVkMDhlZDI0MzhjOWVhMjNiYWQ2YjgyZmYxZjc4YWIwOTZiYjBjZDc1ZDg0ZDU1Yjg2ZTgwMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.ByzxuAOGmIcHd5PuvS6QWttqffvB9AYNN_r0lmujZko)
Log with -d pipe --dump-pipe diffuse
:
dt.txt
from darktable.
from darktable.
Again, while exporting the diffuse module does not appear in the pixel pipe being processed.
from darktable.
I am not sure why, I can assure you the diffuse module is active (and its effect is visible within dt):
from darktable.
I think the log problems have been solved lately in master, from my current understanding we might have similar clmem management "problems" like when using the rusticl driver here. There is #16436 pending, could you test again after that has been merged?
from darktable.
Same problem on export with Darktable 4.6.1 + Linux Gentoo + OpenCL (NVdidia GPU + AMD CPU) : disabling local contrast in "Diffuse or Sharpen" module solves the problem
from darktable.
@fcoiffie could you share a logfile with -d opencl -d tiling -d pipe
?
from darktable.
Ok, can reproduce "some issue" on nvidia/fedora - sounds this could be the underlying "relevant thing"
- reproduce via --conf resourcelevel="notebook" to enforce tiling
- use "toggle hq processing" = on (to process full data)
- it's not the specific preset but related to large values of the radii. darkroom canvas stays black
from darktable.
@fcoiffie could you share a logfile with
-d opencl -d tiling -d pipe
?
from darktable.
@zisoft @fcoiffie could you recheck this on current master? If still failing please share a -d pipe -d opencl
log ...
from darktable.
Looks good! Made several tests now and could not reproduce the issues anymore.
from darktable.
Seems to be fixed in master so closing for now.
from darktable.
Related Issues (20)
- New instance of a module copies the name of former module (auto-named)
- Darktable binaries fails to launch - "free(): invalid pointer" HOT 5
- "Ghost" cameras in wb_presets.json and noiseprofiles.json HOT 8
- Film rolls are removed recursively HOT 4
- Snapshot preview esp when zoomed in does not match preview of the same image used to make the snapshot HOT 6
- Darktable doesn't launch on M1 Max Mac HOT 5
- Intel Open Source AI noise reduction HOT 2
- Minor performance upgrade: Don't update histogram while still computing HOT 3
- Sony UMC-R10C HOT 4
- Strange behavior when going back in history after using a duplicate Composite
- copy/paste of history stack does not include module order unless using selective copy HOT 2
- "Tone equalizer" histogram in "Advanced" tab, doesn't update correctly HOT 2
- darkroom guide lines do not appear in dt 4.7 on Windows HOT 3
- Removing film-roll removes all images recursively HOT 12
- Darktable's extremely slow export HOT 4
- Inconsistent behavior when removing a shape HOT 1
- Crash when Rotate and Perspective module is focussed, grid is showing and using keyboard shortcuts to rotate HOT 11
- history: composite module adds extraneous entries, causes crash on history compress
- Show selected preset for export module HOT 1
- Group ID is altered to Image ID of current group leader HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from darktable.