Comments (5)
@jenshannoschwalm : This is for you :)
from darktable.
A side question, is it expected that almost all tests are slightly changed in the regression testsuite? I mean the new mode is the default but not for old edits, right? For example for recent test Test 0158-coloreq-no-guided-filter we had yesterday:
Test 0158-coloreq-no-guided-filter
Image mire1.cr2
Expected CPU vs. current CPU report :
----------------------------------
Max dE : 0.00000
Avg dE : 0.00000
Std dE : 0.00000
----------------------------------
Pixels below avg + 0 std : 100.00 %
Pixels below avg + 1 std : 100.00 %
Pixels below avg + 3 std : 100.00 %
Pixels below avg + 6 std : 100.00 %
Pixels below avg + 9 std : 100.00 %
----------------------------------
Pixels above tolerance : 0.00 %
OK
So fully clean, 100%... and now:
Test 0158-coloreq-no-guided-filter
Image mire1.cr2
Expected CPU vs. current CPU report :
----------------------------------
Max dE : 0.96704
Avg dE : 0.00004
Std dE : 0.00474
----------------------------------
Pixels below avg + 0 std : 99.99 %
Pixels below avg + 1 std : 99.99 %
Pixels below avg + 3 std : 99.99 %
Pixels below avg + 6 std : 99.99 %
Pixels below avg + 9 std : 99.99 %
----------------------------------
Pixels above tolerance : 0.00 %
OK
from darktable.
The PR #15602 did introduce a regression on this test.
The diff:
The expected output:
The new output:
See the green part in the skip, less redish seems good but it doesn't cover all the area...
So maybe we need:
* to update the integration test * fix segmentation based parameters to cope with PR
I will check if there is a missing part in correction in segmentation stuff ...
from darktable.
A side question, is it expected that almost all tests are slightly changed in the regression testsuite? I mean the new mode is the default but not for old edits, right? For example for recent test Test 0158-coloreq-no-guided-filter we had yesterday:
I think we both agree on this shouldn't be the case :-) (Old edits should have the same output...)
from darktable.
It seems that there is multiple issue.
For example reverting:
fba96f2 Use vectorized functions
Makes test 0158-coloreq-no-guided-filter to be 100% clean again.
But the test in the initial message is still failing.
from darktable.
Related Issues (20)
- Snapshot in the second DR image window
- Panasonic DC-TZ95D raw files unreadable by darktable 4.0 (2024-02-19) HOT 11
- Fatal error in build of dt 4.6.1 HOT 2
- TIFF/JPG snapshots are misaligned against raw file originals HOT 2
- Export function follows active image instead of activation point
- Add the possibility to save the disk backend thumbnail and full view cache as subfolder in rawfiles folder. HOT 3
- Darktable si chiude da solo HOT 2
- Use JXL for thumbnails (if available) HOT 5
- raw chromatic aberrations module not working on Macos Ventura HOT 6
- Could we include the details threshold slider for editing non-raw images HOT 3
- tethering does not work after updating from 4.6.0 to 4.6.1 HOT 14
- Mask opacity is ignored when XMP applied with darktable-cli HOT 5
- Snapshot restore isn't restoring masks, module applied globaly HOT 3
- With selective copying, if you have several instances of the same module, the order of the modules is sorted by access in history and not by hierarchical order HOT 4
- Style with second instance of module overwrites first instance when applied HOT 4
- selective copy paste: copy from lower instance of module overwrites higher instance on paste HOT 2
- Allow to change default path for created xmp files HOT 9
- Glitched images in darkroom due to OpenCL with AMD GPU HOT 21
- DT cannot read some Z50's nef file HOT 8
- avif treated as raw in presets HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from darktable.