Surprising return from insert_at about tablecloth HOT 5 CLOSED

Good point. Let's:

• treat -1 as wrapping, so it inserts in the last position (similar to python)
• if the index is greater than the bounds, put it at the end.

from tablecloth.

Treating -1 as wrapping makes things far more difficult, because people would then expect -2, -3... -len(xs) to work in the same way. I think the “do nothing if out of bounds“ is safest and easiest to implement.

from tablecloth.

Good point, let's do that for now then.

from tablecloth.

The behaviour of this has now changed.

There is a test case demonstrating that when the index is greater than the length of the list then the value is appended.

The documentation examples still refer to the old behaviour and there is no test case for a negative index.

from tablecloth.

Handled this in #224.

It looks like the wrapping behaviour was supported in the rescript version, so I made native match it, and added tests.

Happy to have done it the other way, this was just easier.

from tablecloth.