Comments (4)
@stuartleeks Do you have a repro project that you can share? I threw together a project but do not see that behavior; the workflow completes as expected once all the activities complete, whether .ToList()
is used or not.
from dotnet-sdk.
@philliphoff - I've created a stripped back version of the project where I hit this and pushed it here: https://github.com/stuartleeks/dapr-wf-csharp-1211
Hopefully it's easy to set up/run, but let me kjnow if you have any questions
from dotnet-sdk.
Ok, so found the problem:
await Task.WhenAll(activityTasks);
var result = activityTasks.Select(t=>t.Result).ToArray();
...should instead be:
var result = await Task.WhenAll(activityTasks);
In the original, activityTasks
is a LINQ-based lazily-evaluated IEnumerable<Task>
. It will first be evaluated by the Task.WhenAll()
which causes the activities to be spawned and then awaited. Once that's done, it gets to the activityTasks.Select(t=>t.Result).ToArray()
. This causes a second evaluation of the enumerable which spawns the activities again, but then tries to synchronously wait for each to finish (due to the use of Result
), which is where I think the problem arises.
Task.WhenAll()
returns the results of each awaited Task
so that they can be used without reevaluating the original enumerable.
from dotnet-sdk.
Ah, good spot 🤦
Thanks!
from dotnet-sdk.
Related Issues (20)
- Best way to create a Dapr HttpClient with custom delegating handler? HOT 1
- [Workflow] GRPC connection to workflow runtime doesn't self-heal when app restarts
- Same application doesn't allow to process CloudEvent and raw messages HOT 6
- Azure App Configuration - Feature Flags with Dapr HOT 5
- GetMetadataAsync throws NullReferenceException HOT 1
- Some pods with dapr actors deployed on K8S seem idle HOT 1
- Dapr pub sub with C ++ based application HOT 1
- Have you set the - name: actorStateStore value: "true" in your state store component file? HOT 1
- Passing query string parameters on method invocation HOT 3
- Actor example method invocation doesn't respect method signature HOT 6
- Change Actor methods involving Reminders and Timers from protected to public HOT 3
- Azure Keyvault not loaded by Dapr Client during Asp net core web api app start HOT 2
- Non-Dapr endpoints invocation supported? HOT 6
- .Net implementation of InvokeBinding doesnt return result HOT 1
- Implementing .NET Dapr SDK-wide nullability annotations HOT 1
- [Proposal] Explicitly target latest C# langversion HOT 2
- Jobs API needs a .NET client HOT 1
- [docs] Add Jobs API .NET client example to doc HOT 1
- Add Streaming Subscription Support HOT 16
- Expose a way to pass a self-built CloudEvent to DaprClient HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dotnet-sdk.