Make Error!!! Missing header file!! about magsac HOT 5 CLOSED

I updated the Graph-Cut RANSAC submodule and put some files into new folders.
Apparently, I forgot to update the location in MAGSAC++.
I will soon commit it, but you can easily fix this by replacing
#include "fundamental_estimator.h"
with
#include "estimators/fundamental_estimator.h"

from magsac.

Hey @JonnyG123789 were you able to fix this issue. Please let me know I am to facing the same problem.@danini Can you please help with this?

from magsac.

I updated the Graph-Cut RANSAC submodule and put some files into new folders. Apparently, I forgot to update the location in MAGSAC++. I will soon commit it, but you can easily fix this by replacing #include "fundamental_estimator.h" with #include "estimators/fundamental_estimator.h"

Thanks for the reply.

from magsac.

Hey, @danini I have cloned your newly updated repo I tried to build using - make -. it was almost complete but at the last found the below error which I couldn't understand can you please help me to fix this error.

[ 89%] Building CXX object CMakeFiles/pymagsac.dir/src/pymagsac/include/magsac.cpp.o
[ 94%] Building CXX object CMakeFiles/pymagsac.dir/src/pymagsac/include/model_score.cpp.o
[100%] Linking CXX shared module pymagsac.cpython-37m-x86_64-linux-gnu.so
/usr/bin/ld: libGraphCutRANSAC.a(colmap_models.cpp.o): relocation R_X86_64_PC32 against symbol `_ZN8pose_lib15NullCameraModel9focal_idxE' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/pymagsac.dir/build.make:193: pymagsac.cpython-37m-x86_64-linux-gnu.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:185: CMakeFiles/pymagsac.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

from magsac.

Hey, @danini I have cloned your newly updated repo I tried to build using - make -. it was almost complete but at the last found the below error which I couldn't understand can you please help me to fix this error.

[ 89%] Building CXX object CMakeFiles/pymagsac.dir/src/pymagsac/include/magsac.cpp.o [ 94%] Building CXX object CMakeFiles/pymagsac.dir/src/pymagsac/include/model_score.cpp.o [100%] Linking CXX shared module pymagsac.cpython-37m-x86_64-linux-gnu.so /usr/bin/ld: libGraphCutRANSAC.a(colmap_models.cpp.o): relocation R_X86_64_PC32 against symbol `_ZN8pose_lib15NullCameraModel9focal_idxE' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: bad value collect2: error: ld returned 1 exit status make[2]: *** [CMakeFiles/pymagsac.dir/build.make:193: pymagsac.cpython-37m-x86_64-linux-gnu.so] Error 1 make[1]: *** [CMakeFiles/Makefile2:185: CMakeFiles/pymagsac.dir/all] Error 2 make: *** [Makefile:91: all] Error 2

I think you may fix this by adding “-fPIC” feature in the CMakeLists.txt of Graph-Cut RANSAC submodule.

from magsac.