How should nullable query params be handled without pointers? about huma HOT 4 OPEN

Understood, thank you for the detailed information! I can see why you put off refactoring it :)

The custom resolver route you suggested seems like it might work, so I'm going to play around with that a little bit. If not, I'll deep dive the codebase a bit to see whether I can figure out what needs to be refactored, and whether it makes sense for me to work on it or not.

Thanks again! Huma is such an excellent project :)

from huma.

@wolveix yes this is a little bit of an inconvenience until I can refactor some of the code to potentially support pointer parameters.

For now I suggest using meaningful zero values, so making it that false means no action is taken, same with numbers that are zero, empty string, time.Time.IsZero(), etc. If that's just not possible for some parameter, you can always load it manually using a resolver. Here's a quick example:

https://go.dev/play/p/S9h07SdH4Zr

The downside of using a resolver is you will need to manually document the parameter using e.g. api.OpenAPI().Paths["/your/path"].Get.Parameters....

from huma.

@wolveix unfortunately it's some of the most complex code in the project which glues together all the smaller pieces and takes the cached reflection info to parse and set values on structs. I just haven't had time to refactor / simplify this code.

• Collecting reflection info for params https://github.com/danielgtaylor/huma/blob/main/huma.go#L108
• Result object with Each method https://github.com/danielgtaylor/huma/blob/main/huma.go#L292
• Calling Each to process each value https://github.com/danielgtaylor/huma/blob/main/huma.go#L818

The crux of the problem is that the callback to Every is called with a reflect.Value which in the non-pointer case is already an allocated piece of memory we can easily set. In the pointer case it is not, so it needs to be allocated only when needed and the value must be settable, otherwise you potentially need access to the parent. I'm not 100% sure anymore as it's been a while since I looked into this. Hope that helps, and don't feel bad abandoning this idea due to complexity and unfamiliarity with the codebase!

from huma.

Gotcha, thanks for the suggestions @danielgtaylor! What aspect of the code needs to be refactored to support it? I did have a brief look through, and would be happy to work on this myself if you wouldn't mind pointing out where specifically needs work :)

from huma.