Git Product home page Git Product logo

Comments (9)

ahanriat avatar ahanriat commented on July 24, 2024 1

@michalfeher I think it's because it uses TweenState instead of the React Native Animated Api ;)

from react-native-swipeout.

ahanriat avatar ahanriat commented on July 24, 2024 1

It's because it calls Javascript on each frame. When the dev flag is set to true, each time your component is re rendered (with TweenState), there is a lot of overhead (check of propTypes etc..). When using the Animated Api, you can offThread animations, and update style without re render your component. So even with the dev flag set to true, it will run at 60fps ;)

from react-native-swipeout.

michalfeher avatar michalfeher commented on July 24, 2024

@ahanriat thanks, could be. but building it with the dev flag set to false made it run 60fps :)

from react-native-swipeout.

bsudekum avatar bsudekum commented on July 24, 2024

I'm also seeing poor performance. It seems to happen the most after heavy scrolling.
3

This is with the dev flag set to true.

from react-native-swipeout.

ahanriat avatar ahanriat commented on July 24, 2024

Whaooo that's rude ! You should try this branch https://github.com/dancormier/react-native-swipeout/tree/dc-redux, it use Animated Api 😄

from react-native-swipeout.

bsudekum avatar bsudekum commented on July 24, 2024

@ahanriat this is not a jab at you nor your code, simply an observation. I'll check out the branch.

from react-native-swipeout.

dancormier avatar dancormier commented on July 24, 2024

Hi @ahanriat @bsudekum @michalfeher and others,

The current master does use tween-state, which creates this laggy performance. The branch @ahanriat referenced is not yet ready for release, but it's almost done and it does use the RN Animated
API. Hopefully, I can find some time to wrap it up and release this majorly updated version soon. All contributions are welcome!

@bsudekum to clear up any confusion, I don't believe @ahanriat was bothered by your comment, since it's my code causing the issues in that image ;) I think he was trying to articulate that the performance shown in that gif is poor and needs to be remedied (which I agree with)!

from react-native-swipeout.

dancormier avatar dancormier commented on July 24, 2024

Also, for anyone wondering what's left for the next major update:

https://github.com/dancormier/react-native-swipeout/tree/dc-redux#to-do-for-v300-issues

^ feel free to knock out any of those issues as you see fit to expedite the release of v3 of swipeout.

from react-native-swipeout.

ahanriat avatar ahanriat commented on July 24, 2024

Yeah sorry for the confusion, I just wanted to say that the animation was very very slow ;)

from react-native-swipeout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.