Git Product home page Git Product logo

Comments (6)

damianavila avatar damianavila commented on July 30, 2024

Probably we have to add 2.3.0 to this line... https://github.com/damianavila/live_reveal/blob/master/livereveal/main.js#L25

I will try to push a fix soon. Thanks for the report...

from rise.

mhardcastle avatar mhardcastle commented on July 30, 2024

You certainly do have to fix main.js, but the fontawesome icons just aren't there on my system unless I manually install them...

from rise.

damianavila avatar damianavila commented on July 30, 2024

mmm... that's weird... did you try hard cleaning your browser cache? IIRC, fontawesome is installed with IPython...

from rise.

mhardcastle avatar mhardcastle commented on July 30, 2024

You may be right, but it doesn't appear on a fresh pip install ipython[notebook] of 2.3.0.

EDIT: sorry, that should be 'doesn't appear to work'. font-awesome is indeed installed with ipython.

I will try to do a clean installation of notebook and live-reveal and see if the problem is still there once you have pushed a fix for the main.js version check.

from rise.

damianavila avatar damianavila commented on July 30, 2024

Solved on master... pinging @jjconti and @mwiebe, who also reported me this problem before.
Tested on IPython 2.3.0 and also tested in current Jupyter master (e9c0f45) and all the buttons are working as expected.

from rise.

jjconti avatar jjconti commented on July 30, 2024

Thanks.

from rise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.