Query for databases not scraped properly? about ldap2pg HOT 5 CLOSED

@bersace Nice work. Thanks for the great follow-up.
Closing this.

from ldap2pg.

Hi @Stanislasss , thanks for the report !

database_query: |

In your YML, it looks like you missed s in databases_query. Can you try with this ?

And by the way, why are you doing your own mapping and not using something like: https://pyyaml.org/wiki/PyYAML ?

That would be great to drop duplicated code in ldap2pg ! ldap2pg is already using pyyaml to parse ldap2pg.yml. Can you elaborate on what you mean by your own mapping ?

From your report, I sugget to improve ldap2pg this way:

• Gracefully handle connection errors
• Warn on unknown configuration entry.

Do you have some more ideas ?

from ldap2pg.

Hi @bersace,

Impressive fast answer.
I'm really sorry, I did missed the 's' on the yaml block.
Regarding the "pyyaml" module, I see it as a requirement, but cannot find where you use it in the code.
By the way, I'm a complete beginner with Python and Development in general so excuse the sluggish coder eyes.
As you already helped me with my configuration file mistake, I do not want to make you lose your time, so only answer if you're keen to.

• "Warn on unknown configuration entry", it would be great.
• "Gracefully handle connection errors", what do you think of?

No more ideas regarding the tool behavior, but I just started with is it so may be later on.
And you tool is greatly done! (Documentation, Configuration,...) Thanks for sharing this work.
I might have a request on more comments in your code but this only because things are still a bit obscure to me as being a newbie and definitly understand if you are not interested into it.

Otherwise are you still interested in having someone creating a Dockerfile for it?
If yes any best practices recommendations?

And do you know where I could get some documentation on how to configure ldap to use ldaps or starttls with your tool?

from ldap2pg.

Hi @Stanislasss

No worry for your level :-) For your information, ldap2pg config loading is in ldap2pg/config.py file : https://github.com/dalibo/ldap2pg/blob/master/ldap2pg/config.py#L561-L566

Youre experience as a newcomer is very welcome. If you fight with ldap2pg that's a bug ;-). ldap2pg just expects you to know basically how to manually setup a ldap authenticated role in Postgres.

Yes, there is an issue about Dockerfile : #202 . PR welcome ! I tend to reduce image size. Also, i would like to ship only released version in Dockerfile. Let's talk about this on #202 or on a PR. Any starting point would be good :-)

Please keep this issue opened until I resolved the two improvements. Would you like to tell me if everything went well once you're done ?

from ldap2pg.

Sure thing, I'll let the ticket opened until then, and let you know about my setup experience. ;-)

from ldap2pg.