Git Product home page Git Product logo

Comments (3)

dcposch avatar dcposch commented on August 14, 2024
image

from daimo.

dcposch avatar dcposch commented on August 14, 2024

Investigation

this comes from the following change

 export type PreSwapTransfer = {
-  coin: ForeignCoin;
+  coin: ForeignToken;

https://github.com/daimo-eth/daimo/pull/1178/files#diff-9eab1d56a27be76232c70c1f6bff31c5e9f293f835ad991068443cbd680b9d91L41

issue is that this changes the Account StoredModel. user accounts stored locally have recentTransfers: DisplayOpEvent[], which can have preSwapTransfer

cc @kayleegeorge

fix coming soon. i have a way to do this that'll also catch account stored model type changes going forward

from daimo.

dcposch avatar dcposch commented on August 14, 2024

Test plan

Add a unit test that loads examples of old serialized accounts. These will be more complete accounts, not the empty ones currently in account.test.ts. Ensure correct migration.

from daimo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.