Comments (6)
It is because updatesRates
is called before GlobalStateProvider
is initialized.
Can you move useEffect in components under GlobalStateProvider?
I'm not sure how we can resolve this in general. Basically the use of setGlobalState
is not recommended in this case and I'd use const setRates = useGlobalState('rates')[1]
.
(edit) There was my misunderstanding at first. There is no issue with initialization. The use of setGlobalState
is fine and is better for performance in certain cases. You could even call it outside of GlobalStateProvider
, but I wouldn't recommend it.
from react-hooks-global-state.
I tried moving it to the Routes
component. It runs fine, however the same problem happens.
I didn't understand what you meant with const setRates = useGlobalState('rates')[1]
I tried to follow the fetch and onmount examples, but it didn't work
from react-hooks-global-state.
I tried moving it to the Routes component. It runs fine, however the same problem happens.
Sorry. There might be something I misunderstand.
Could you provide a codesandbox to reproduce the problem please?
https://codesandbox.io/s/github/dai-shi/react-hooks-global-state/tree/master/examples/05_onmount
This example without modification is working for you, correct?
from react-hooks-global-state.
Could you provide a codesandbox to reproduce the problem please?
Yes: https://codesandbox.io/s/82kyyqw98j I just hard coded the setRates, because I won't integrate my API in codesandbox. But it replicates the issue.
This example without modification is working for you, correct?
I didn't try it, however I based my implementation using this one.
from react-hooks-global-state.
@otaviobps Thanks for the code.
It's nothing to do with initialization which I mentioned in the first comment.
It's simply the usage of setGlobalState
. The correct one is the following:
export const setRates = obj => {
setGlobalState('loading', false);
setGlobalState('rates', obj);
};
I didn't understand what you meant with
const setRates = useGlobalState('rates')[1]
This is what I mean.
const Routes = () => {
const setRates = useGlobalState('rates')[1];
const setLoading = useGlobalState('loading')[1];
useEffect(() => {
setRates(2);
setLoading(false);
}, []);
return (
<BrowserRouter>
<Switch>
<Route exact path="/" component={Main} />
<Route path="*" component={() => <h1>Page not found</h1>} />
</Switch>
</BrowserRouter>
);
};
But, this will trigger re-render if rates
or loading
in state is changed.
So, setGlobalState
would be better for performance. (My recommendation in the first comment is wrong.)
from react-hooks-global-state.
Closing this for inactivity. Feel free to reopen it.
from react-hooks-global-state.
Related Issues (20)
- getGlobalState should not be used in render HOT 5
- Error calling createStore (Typescript 3.6.4) HOT 2
- Question: how do developers use this library? HOT 1
- Please add CHANGELOG for 0.17.0 HOT 1
- getGlobalState loses sync with useGlobalState after 0.17 HOT 8
- How to use Redux Devtools Extension HOT 3
- comparison to react-tracked and initial values for a state HOT 9
- Error: You cannot use <GlobalStateProvider> more than once. HOT 5
- How to separate reducer and Action Type then call it to combineReducers (Ex: 07_middleware) HOT 3
- Offline saved data for React Native HOT 11
- Be able to access multiple state keys with a single hook HOT 3
- Mocking useGlobalState with jest? HOT 8
- Restoring initial state from localStorage, if any? HOT 10
- global state not preserved with Fast Refresh HOT 2
- Argument of type '"cart"' is not assignable to parameter of type 'never' HOT 5
- Asynchronous initial state HOT 4
- Is it possible to change a value outside a component? HOT 2
- Persistence with createGlobalState HOT 6
- How to easily reset state? HOT 1
- How to update the state in Bulk ? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-hooks-global-state.