Git Product home page Git Product logo

Comments (5)

AshisGhosh avatar AshisGhosh commented on June 7, 2024 1

LGTM!
My only suggestion would be to make the copy_from and sequence_id variables more explicit. E.g. fork_from_app_id, fork_at_sequence_id

from burr.

skrawcz avatar skrawcz commented on June 7, 2024 1

@AshisGhosh @elijahbenizzy I have:

.initialize_from(
        initializer=tracker,
        resume_at_next_action=False, # we want to always start at human_converse; our entrypoint
        default_entrypoint="human_converse",
        default_state=initial_state, # set some default state incase we can't find the prior state
        fork_from_app_id=prior_app_id, # <---- The new addition 
        fork_from_partition_key="sample_user",  # <---- The new addition 
        fork_from_sequence_id=5,  # <---- The new addition 
    )

working here - #184

Let me know your API feedback/thoughts.

from burr.

elijahbenizzy avatar elijahbenizzy commented on June 7, 2024

@AshisGhosh @elijahbenizzy I have:

.initialize_from(
        initializer=tracker,
        resume_at_next_action=False, # we want to always start at human_converse; our entrypoint
        default_entrypoint="human_converse",
        default_state=initial_state, # set some default state incase we can't find the prior state
        fork_from_app_id=prior_app_id, # <---- The new addition 
        fork_from_partition_key="sample_user",  # <---- The new addition 
        fork_from_sequence_id=5,  # <---- The new addition 
    )

working here - #184

Let me know your API feedback/thoughts.

I like it. Feels consistent -- there's:

  1. fork_from_* -- this is where its loaded from
  2. with_identifiers -- this is where its saved to

from burr.

AshisGhosh avatar AshisGhosh commented on June 7, 2024

@AshisGhosh @elijahbenizzy I have:

.initialize_from(
        initializer=tracker,
        resume_at_next_action=False, # we want to always start at human_converse; our entrypoint
        default_entrypoint="human_converse",
        default_state=initial_state, # set some default state incase we can't find the prior state
        fork_from_app_id=prior_app_id, # <---- The new addition 
        fork_from_partition_key="sample_user",  # <---- The new addition 
        fork_from_sequence_id=5,  # <---- The new addition 
    )

working here - #184
Let me know your API feedback/thoughts.

I like it. Feels consistent -- there's:

  1. fork_from_* -- this is where its loaded from
  2. with_identifiers -- this is where its saved to

Yes, I'm a fan! The flow to revisit a point and branch off is very clear.

from burr.

skrawcz avatar skrawcz commented on June 7, 2024

Okay PR is ready I think.

Going to leave "Wire through the parent ID" to the UI and persisters as something for later as that's a more involved change. i.e. would be nice to see in the UI what you forked from. See #185.

from burr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.