k8sRunLauncher.runK8sConfig.containerConfig overridden by dagster-user-deployments.deployments[0].resources about dagster HOT 4 CLOSED

Hi @NiallRees - is setting the "includeConfigInLaunchedRuns" option to False an option here? https://docs.dagster.io/deployment/guides/kubernetes/deploying-with-helm#step-61-configure-the-deployment

Or is there other configuration from the code server that you do want to apply to launched runs?

The reason this changed when you moved to 1.7.0 is the merge behavior change listed here: https://docs.dagster.io/changelog?page=3#breaking-changes-1

"[dagster-k8s] The default merge behavior when raw kubernetes config is supplied at multiple scopes (for example, at the instance level and for a particular job) has been changed to be more consistent. Previously, configuration was merged shallowly by default, with fields replacing other fields instead of appending or merging. Now, it is merged deeply by default, with lists appended to each other and dictionaries merged, in order to be more consistent with how kubernetes configuration is combined in all other places. See the docs for more information, including how to restore the previous default merge behavior."

I appreciate that in this specific instance this leads to an unexpected interaction since you are setting this configuration on your run launcher with the intention of it applying to your runs but then its getting overridden by code-server-specific configuration.

from dagster.

There's a similar issue here I think: #13921

from dagster.

Thanks @gibsondan - that makes sense. I haven't tested setting includeConfigInLaunchedRuns to False. It would make sense to me that with includeConfigInLaunchedRuns = True, it wouldn't override configuration explicitly set for the runs. I can get by for now simply by setting the required resources for the run on the code server too, and I'm happy with that, so happy to close.

from dagster.

Got it - will move the discussion to the linked issue, but sorry for the rough edge here - we'll see what we can do to make this better match your intent.

from dagster.