Git Product home page Git Product logo

Comments (4)

garethbrickman avatar garethbrickman commented on August 25, 2024

Relates to this commit: b326b97

from dagster.

sryza avatar sryza commented on August 25, 2024

Hey @zyd14 - this isn't set in stone, but the two main reasons we went in this direction were:

  • Tags are key-value pairs, and it's easy for "a:b" to look like "a" is the key and "b" is the value
  • We largely cargo-culted the Kubernetes syntax for labels, for the sake of consistency and because they seem to have a pretty principled approach

from dagster.

zyd14 avatar zyd14 commented on August 25, 2024

Fair points. We took inspiration from AWS as that's where most of our tags surface anyway and they do colon-separated namespaces for keys. I've ran into a few services that don't allow it now though which makes me feel like maybe we've got it wrong.

from dagster.

sryza avatar sryza commented on August 25, 2024

To be clear, I think it is extremely unlikely that we'd actually be able to drop support for these keys. The deprecation warning is there to guide new users towards a particular direction, which will allow us to build UI that favors it (e.g. visually distinguishing the part before and after the "/").

If the deprecation warning itself is cramping your style, we might be able to add a way to disable it more comprehensively in your setup?

from dagster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.