Git Product home page Git Product logo

Comments (9)

dafzor avatar dafzor commented on August 20, 2024 1

It's weird, on my system I don't run it as admin and returns proper results, did you change/disable the UAC settings or run the game as admin by any chance?

from bnetlauncher.

sorashi avatar sorashi commented on August 20, 2024

Just saw your commits you made 3 days ago. It seems you already know about it. I tried reinstalling the Battle.Net client, it didn't help. I also tried cloning your code, building it and using it instead (to reflect your recent changes).

from bnetlauncher.

dafzor avatar dafzor commented on August 20, 2024

I have Overwatch and it's currently working with bnetlauncher when i launch it, with or without battle.net client running.

As for your test,

"If you did not use the Start method to start a process, the StartInfo property does not reflect the parameters used to start the process. For example, if you use GetProcesses to get an array of processes running on the computer, the StartInfo property of each Process does not contain the original file name or arguments used to start the process." in Process.StartInfo documentation

That is the reason why I use System.Management API to retrieve the StartInfo, should have probably added a comment about it.

As remarked in the GetProcessStartInfoById it does sometime fail which is why I have retry code but I have never had it return empty values, so at least locally I can't seem to reproduce the issue, I could try fixing it by adding a check for empty and retry but would prefer to try and figure out what's going on before I "fix it".

from bnetlauncher.

dafzor avatar dafzor commented on August 20, 2024

Could you enable the log file and send it over?

from bnetlauncher.

sorashi avatar sorashi commented on August 20, 2024

The log: http://pastebin.com/7XFDtvhU

from bnetlauncher.

sorashi avatar sorashi commented on August 20, 2024

I'll try debugging and finding the cause. I know there isn't much you can do about it - seems I'm the only one having the issue.

from bnetlauncher.

sorashi avatar sorashi commented on August 20, 2024

So I debugged it and found the problem. The searcher.Get() was returning an empty collection, so it wasn't throwing any exception. It just skipped the foreach loop and continued trying.
Debugging

I thought - maybe it was a permission problem. So I tried setting bnetlauncher.exe to always run as an administrator and it works now.

I can see though, that you have <requestedExecutionLevel level="asInvoker" uiAccess="false" /> in app.manifest, so it should require the permission automatically.

So I assume my OS is acting weird and it is not your app's problem.

Thanks for this great app and good luck with future development. And sorry that I bothered you with this without even trying such a basic thing like running it as an administrator.

from bnetlauncher.

sorashi avatar sorashi commented on August 20, 2024

Yes, my UAC is set to never notify and I have set Overwatch to run as an administrator. That was exactly the problem.

from bnetlauncher.

dafzor avatar dafzor commented on August 20, 2024

I'll try and see if there's any way to fix it or at the very least provide some warnings about it, thanks for all the testing and debugging.

from bnetlauncher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.