Git Product home page Git Product logo

Comments (19)

d4rken avatar d4rken commented on June 1, 2024 2

Found the issue. Proguard/R8 was removing important code related to root operations in release mode.

Should be fixed in the next release. Thanks for detailed logs!

Double bug this one, nice catch 😄.

from sdmaid-se.

d4rken avatar d4rken commented on June 1, 2024

Fully agree. I thought this would already work, will look into it.

from sdmaid-se.

Rokcy98 avatar Rokcy98 commented on June 1, 2024

The problem doesn't seem to be solved: rooted here, when trying to clean apps it tells me accessibility service is no more enabled, and it can't clean

from sdmaid-se.

d4rken avatar d4rken commented on June 1, 2024

Can you get me a debug log of this?
What are your AppCleaner settings?

from sdmaid-se.

d4rken avatar d4rken commented on June 1, 2024

Are you sure you are on the latest build?
Should be fixed as of 0.6.5-beta0.
Couldn't reproduce on a Pixel 3A 🙁

from sdmaid-se.

Rokcy98 avatar Rokcy98 commented on June 1, 2024

Screenshot_20230326-183808
This one is with "include inaccessible data" enabled, root and no accessibility
eu.darken.sdmse_logfile_1679848973025.log

Screenshot_20230326-183823
This one with "include inaccessible data" disabled, root and no accessibility
eu.darken.sdmse_logfile_1679848933674.log

from sdmaid-se.

JesseRacine avatar JesseRacine commented on June 1, 2024

Here is a log file from me with the latest version. This is where I try to delete app files and the app complains about accessibility not being enabled, even though it has root.
eu.darken.sdmse_logfile_1679747982086.log.zip

from sdmaid-se.

d4rken avatar d4rken commented on June 1, 2024

If you go into settings and setup, can you show me the accessibility setup card?

from sdmaid-se.

Rokcy98 avatar Rokcy98 commented on June 1, 2024

Screenshot_20230326-190523

from sdmaid-se.

Rokcy98 avatar Rokcy98 commented on June 1, 2024

It seems like that @JesseRacine and I are talking about the same problem btw, we should have the ability to bypass accessibility permission with root, like on sd maid

from sdmaid-se.

d4rken avatar d4rken commented on June 1, 2024

@Rokcy98 SD Maid has no root in your first or second log.
Check Magisk and make sure SD Maid actually has root access.

@JesseRacine I don't think your log is from 0.6.5-beta0, please update and try again. The log seems to be from 0.6.4 or earlier and only contains a bit of the accessibility service and lots of SystemCleaner entries. Make sure you start the log before the error occurs.

from sdmaid-se.

JesseRacine avatar JesseRacine commented on June 1, 2024

@JesseRacine I don't think your log is from 0.6.5-beta0, please update and try again. The log seems to be from 0.6.4 or earlier and only contains a bit of the accessibility service and lots of SystemCleaner entries. Make sure you start the log before the error occurs.

@d4rken I'm sorry about that, I had uploaded the wrong log and I wasn't even on the proper beta. I've switched to the correct beta and recorded a log for you. Please see here.
eu.darken.sdmse_logfile_1679861946459.log.zip

from sdmaid-se.

d4rken avatar d4rken commented on June 1, 2024

@d4rken I'm sorry about that, I had uploaded the wrong log and I wasn't even on the proper beta. I've switched to the correct beta and recorded a log for you. Please see here. eu.darken.sdmse_logfile_1679861946459.log.zip

Also looks like no root. While the log doesn't contain the AppCleaner search, the init info only shows public storage, if SD Maid loaded with root, it should also display private data areas.

What does Magisk show for SD Maid SE?

023-03-26T20:19:06.463Z  I/SDMSE:Debug:Log:Recorder:Module: Data areas: (4)
2023-03-26T20:19:06.463Z  I/SDMSE:Debug:Log:Recorder:Module: #0 DataArea(path=LocalPath(/storage/emulated/0), type=SDCARD, label=eu.darken.sdmse.common.ca.CaStringKt$caString$1@2e490c1, flags=[PRIMARY], userHandle=UserHandle2(handleId=0))
2023-03-26T20:19:06.463Z  I/SDMSE:Debug:Log:Recorder:Module: #1 DataArea(path=LocalPath(/storage/emulated/0/Android/media), type=PUBLIC_MEDIA, label=eu.darken.sdmse.common.ca.CaStringKt$caString$1@5c2b7af, flags=[PRIMARY], userHandle=UserHandle2(handleId=0))
2023-03-26T20:19:06.463Z  I/SDMSE:Debug:Log:Recorder:Module: #2 DataArea(path=SAFFile(treeRoot=content://com.android.externalstorage.documents/tree/primary, segments=[Android, obb]), type=PUBLIC_OBB, label=eu.darken.sdmse.common.ca.CaStringKt$caString$1@839b7bc, flags=[PRIMARY], userHandle=UserHandle2(handleId=0))
2023-03-26T20:19:06.463Z  I/SDMSE:Debug:Log:Recorder:Module: #3 DataArea(path=SAFFile(treeRoot=content://com.android.externalstorage.documents/tree/primary, segments=[Android, data]), type=PUBLIC_DATA, label=eu.darken.sdmse.common.ca.CaStringKt$caString$1@df6b345, flags=[PRIMARY], userHandle=UserHandle2(handleId=0))

from sdmaid-se.

JesseRacine avatar JesseRacine commented on June 1, 2024

Hmmm, I'm not sure how to get it working with root then. SD Maid will request access for root and I grant it, and the root access shows up in Magisk. Here's a screenshot.
photo_2023-03-26_16-40-24

from sdmaid-se.

d4rken avatar d4rken commented on June 1, 2024

Can you do this:

  • Start debug log
  • Force stop SD Maid
  • Open SD Maid
  • Go to Settings > Setup (just open the screen)
  • Then return to the dashboard again and scan + delete AppCleaner
  • Stop and share the debug log with me.

Something with how SD Maid uses root seems to be broken?

from sdmaid-se.

JesseRacine avatar JesseRacine commented on June 1, 2024

Ok, please see here.

eu.darken.sdmse_logfile_1679866180526.log.zip

from sdmaid-se.

d4rken avatar d4rken commented on June 1, 2024

Seems this is not related to accessibility at all so far.
Root just isn't working 😦
Not yet sure why.

2023-03-26T21:30:15.451Z  D/SDMSE:Root:Java:Client: Instantiating RootHost launcher...
2023-03-26T21:30:15.451Z  D/SDMSE:Root:Java:Host:Launcher: Initiating connection to host.
2023-03-26T21:30:15.451Z  D/SDMSE:Root:Host:Launcher: createConnection(class eu.darken.sdmse.common.root.javaroot.JavaRootConnection,class eu.darken.sdmse.common.root.javaroot.JavaRootHost,true,false)
2023-03-26T21:30:15.452Z  I/SDMSE:Root:Host:Launcher: Initiating connection to host(class eu.darken.sdmse.common.root.javaroot.JavaRootHost) via binder(class eu.darken.sdmse.common.root.javaroot.JavaRootConnection)
2023-03-26T21:30:15.458Z  D/SDMSE:RootHostCmdBuilder: build(relocate=false, RootHostOptions(packageName=eu.darken.sdmse, pairingCode=548535a6-87e2-4fbc-8f25-dde0c977e3f0, isDebug=true, isTrace=true, waitForDebugger=false))
2023-03-26T21:30:15.458Z  D/SDMSE:Root:Java:Host:CmdBuilder: Launch command: CLASSPATH=/data/app/~~2aVVmN_YhxlSkdW32iPOsA==/eu.darken.sdmse-U_zMY__op8gPKxFjzkReeg==/base.apk exec /proc/14587/exe -XjdwpProvider:adbconnection -XjdwpOptions:suspend=n,server=y /system/bin --nice-name=eu.darken.sdmse:root:eu.darken.sdmse.common.root.javaroot.JavaRootHost eu.darken.sdmse.common.root.javaroot.JavaRootHost
2023-03-26T21:30:15.458Z  D/SDMSE:Root:Java:Host:CmdBuilder: Launch command with options: CLASSPATH=/data/app/~~2aVVmN_YhxlSkdW32iPOsA==/eu.darken.sdmse-U_zMY__op8gPKxFjzkReeg==/base.apk exec /proc/14587/exe -XjdwpProvider:adbconnection -XjdwpOptions:suspend=n,server=y /system/bin --nice-name=eu.darken.sdmse:root:eu.darken.sdmse.common.root.javaroot.JavaRootHost eu.darken.sdmse.common.root.javaroot.JavaRootHost ROOT_HOST_OPTIONS=PQAAAGUAdQAuAGQAYQByAGsAZQBuAC4AcwBkAG0AcwBlAC4AYwBvAG0AbQBvAG4ALgByAG8AbwB0AC4AagBhAHYAYQByAG8AbwB0AC4AaQBuAHQAZQByAG4AYQBsAC4AUgBvAG8AdABIAG8AcwB0AE8AcAB0AGkAbwBuAHMAAAAPAAAAZQB1AC4AZABhAHIAawBlAG4ALgBzAGQAbQBzAGUAAAAkAAAANQA0ADgANQAzADUAYQA2AC0AOAA3AGUAMgAtADQAZgBiAGMALQA4AGYAMgA1AC0AZABkAGUAMABjADkANwA3AGUAMwBmADAAAAAAAAEAAAABAAAAAAAAAA==
2023-03-26T21:30:15.458Z  D/SDMSE:ProducerCoroutine: RootHost launch command is eu.darken.rxshell.cmd.Cmd$Builder@bdca6dc
2023-03-26T21:30:15.850Z  D/SDMSE:Root:Host:Launcher: Root host launch result was: Cmd.Result(cmd=Cmd(timeout=0, commands=[CLASSPATH=/data/app/~~2aVVmN_YhxlSkdW32iPOsA==/eu.darken.sdmse-U_zMY__op8gPKxFjzkReeg==/base.apk exec /proc/14587/exe -XjdwpProvider:adbconnection -XjdwpOptions:suspend=n,server=y /system/bin --nice-name=eu.darken.sdmse:root:eu.darken.sdmse.common.root.javaroot.JavaRootHost eu.darken.sdmse.common.root.javaroot.JavaRootHost ROOT_HOST_OPTIONS=PQAAAGUAdQAuAGQAYQByAGsAZQBuAC4AcwBkAG0AcwBlAC4AYwBvAG0AbQBvAG4ALgByAG8AbwB0AC4AagBhAHYAYQByAG8AbwB0AC4AaQBuAHQAZQByAG4AYQBsAC4AUgBvAG8AdABIAG8AcwB0AE8AcAB0AGkAbwBuAHMAAAAPAAAAZQB1AC4AZABhAHIAawBlAG4ALgBzAGQAbQBzAGUAAAAkAAAANQA0ADgANQAzADUAYQA2AC0AOAA3AGUAMgAtADQAZgBiAGMALQA4AGYAMgA1AC0AZABkAGUAMABjADkANwA3AGUAMwBmADAAAAAAAAEAAAABAAAAAAAAAA==]), exitcode=-3, output.size()=0, errors.size()=0)
2023-03-26T21:30:15.851Z  D/SDMSE:Root:Host:Launcher: Canceling!
2023-03-26T21:30:15.852Z  E/SDMSE:Root:Java:Host:Launcher: Failed to establish connection: eu.darken.sdmse.common.root.javaroot.internal.RootException: Shell died launching the java root host.

from sdmaid-se.

JesseRacine avatar JesseRacine commented on June 1, 2024

Ok I'll be able to test it out later today.

I have another possible root issue where system files can't be accessed with root. I can test that out again too. If I still have problems with the system files I'm going to compare the behavior with the original SD Maid first before giving any more details.

from sdmaid-se.

jont4 avatar jont4 commented on June 1, 2024

here it's OK now.
Root working as expected

from sdmaid-se.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.