Git Product home page Git Product logo

Comments (3)

pmenzel avatar pmenzel commented on May 2, 2024 1

Alright, didn't see that the implementation is different here than in D3, sorry! Yeah, the location of intersecting circle is just denoted as "before" and "after" the currently placed circle in the paper, which is a bit confusing.

from d3-hierarchy.

mbostock avatar mbostock commented on May 2, 2024

That was a mistake inherited from the Flare implementation on which the Protovis implementation was based. I’ve since completely rewritten the circle-packing layout for D3 4.0 in this repository and it no longer has this behavior.

from d3-hierarchy.

mbostock avatar mbostock commented on May 2, 2024

The Flare implementation (and by extension Protovis and D3 < 4) had another problem where the “closest” intersecting circle was measured topologically rather than based on the cumulative length of each segment in the front chain (see s2 < s1). The paper isn’t clear what “closest” means, but by measuring the traversed length of the front chain it appears to avoid some edge cases where the previous implementation can generate overlapping circles.

from d3-hierarchy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.