Comments (2)
I think it should be
self.optim.zero_grad()
loss.backward()
with torch.no_grad():
self.optim.step()
from d2l-en.
I think it should be
self.optim.zero_grad() loss.backward() with torch.no_grad(): self.optim.step()
Apologies for not being clear earlier. I'm uncertain about the correctness of a specific part of the code found at https://github.com/d2l-ai/d2l-en/blob/master/d2l/torch.py. Here is the original code:
def fit_epoch(self):
"""Defined in :numref:`sec_linear_scratch`"""
self.model.train()
for batch in self.train_dataloader:
loss = self.model.training_step(self.prepare_batch(batch))
self.optim.zero_grad()
with torch.no_grad():
loss.backward()
if self.gradient_clip_val > 0: # To be discussed later
self.clip_gradients(self.gradient_clip_val, self.model)
self.optim.step()
self.train_batch_idx += 1
if self.val_dataloader is None:
return
self.model.eval()
for batch in self.val_dataloader:
with torch.no_grad():
self.model.validation_step(self.prepare_batch(batch))
self.val_batch_idx += 1
from d2l-en.
Related Issues (20)
- module 'd2l.torch' has no attribute 'count_corpus' HOT 3
- A question about 4.7.3.3. Label Shift Correction HOT 1
- PyTorch Colab of Chapter 13.5 is having an IndexError HOT 2
- Free copy for the first 100 contributors
- Ethics?
- MLX support HOT 1
- Add type hinting to functions HOT 1
- Not able to render :begin_tab:toc
- Errors in train_ch3 in tensorflow version softmax-regression-scratch.ipynb HOT 1
- [**emergency**] the comment block is down, please fix it right now HOT 1
- Chinese version of the code is out of date
- The discussion link can not be accessed. HOT 7
- The mlm loss computation in the function _get_batch_loss_bert seems wrong in d2l pytorch code HOT 2
- Can't build the book on MacOS when trying to add MLX implementation
- Some issues with the book
- WikiText-2 is not a zip file HOT 2
- question about ”d2l = sys.modules[__name__]“
- Website of preview version is down. HOT 5
- The content is outdated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d2l-en.