Reassigning entry names causes stack overflow error about laravel-breadcrumbs HOT 7 CLOSED

What's the error message?

https://github.com/davejamesmiller/laravel-breadcrumbs/blob/master/CONTRIBUTING.rst

from laravel-breadcrumbs.

Sorry for not providing the necessary details.
Apache log says:

[Thu Mar 19 17:09:29.843727 2015] [mpm_winnt:notice] [pid 4372:tid 388] AH00428: Parent: child process 3944 exited with status 3221225725 -- Restarting.

322..725 seems to be a stack overflow error.

PHP log says nothing.

The above description will not reproduce the error, it was a false analysis on my end.
The real issue seems to be when you try to register multiple breadcrumb entries with the same name. I had one registration left in another file and ended up registering two breadcrumb entries for the name "admin.job.index".

I don't quite get what goes wrong though as the register method should simply overwrite the prior entry, no?

public function register($name, $callback)
{
    $this->callbacks[$name] = $callback;
}

/src/Manager.php: 20

Once you catch the case where the desired name has already been taken you can throw an exception and exit before the crash of Apache.

if (isset($this->callbacks[$name]))
    throw new Exception("Entry name \"{$name}\" has already been assigned."

I've not been able to unset or reset the prior registered one. I would guess "simply overwrite the previous assignment" would be the desired functionality here but at least on my machine that won't work.

from laravel-breadcrumbs.

I can't see any reason that defining a breadcrumb twice would cause a problem - as you say it should just overwrite it. Are you sure you're not calling it in a way that would cause an infinite loop - e.g. parent() calling itself?

from laravel-breadcrumbs.

🙈

Breadcrumbs::register( 'admin.job.index', function( $breadcrumbs ) {
    $breadcrumbs->push( 'Overview', route( 'admin.job.index' ) );
} );

Breadcrumbs::register( 'admin.job.index', function( $breadcrumbs ) {
    // YOLO
    $breadcrumbs->parent( 'admin.job.index' ); 
    $breadcrumbs->push( 'Overview', route( 'admin.job.index' ) );
} );

Yup, reproduced it like so - I guess that was the original code that caused it.
Sorry for the mess.

from laravel-breadcrumbs.

:)

from laravel-breadcrumbs.

BTW You might want to look at your PHP setup, because on most systems that would cause a "maximum nesting level reached" PHP error, output to the screen or log, not a stack overflow / cryptic error.

from laravel-breadcrumbs.

Yes thanks for the heads up, I am currently looking into that, bugged me as well :)

from laravel-breadcrumbs.