GCS Input - RSSI: Can we / how could I add "iBus" option? about dronin HOT 11 CLOSED

Not so much 'flaunting' per sei, but I was intrigued to try out an alternative control system for sure.
Quad was a 'little' too noisy for good performance so I haven't had much to shout about ;)
/offtopic

PR created. Thanks @tracernz
#2246

from dronin.

I saw your messages on IRC, but you had quit already. I'm a little hazy on how that works, it's been a while since I worked on RSSI or wrote the IBus driver.

Places that definitely need additions:

Of interest:

Does the RSSI come through as a channel, or a dedicated field in the frame? Should be easy for the former. For the latter you could either fake a channel in the driver, or implement a method that transmitter_control.c can call to get RSSI, and add the necessary bit in there.

from dronin.

Thanks for your reply.

Great work on the driver by the way, it works perfectly :) I don't think we'll need to delve into that code specifically because the controller does the hard work for you.

Once the brilliant FlyPlus firmware has been flashed to the Tx it enables you (amongst other benefits - timers, alarms, etc) to simply select 'ERROR' as a source for the aux channels of your choice. Exactly how you would normally assign a switch or VRA/B to the AUX channels. It also enables transmission of AETR+12aux assignable channels without added latency (sourced from https://github.com/benb0jangles/FlySky-i6-Mod- )
As you said, RSSI comes through as a channel.
Setting an AUX to use ERROR modifies the output of the channel between 1000uS-2000uS based on the RSSI calculated by the FS-i6 internally. 0% RSSI = 1000uS and 100% = 2000uS.

All we would need to do is enable the option within dRGCS to allow iBus input with a selectable channel, identical to how a standard PWM input would be read but over iBus instead of needing to use a dedicated DAC and break out wire from the Rx.

I did try adding an entry in manualcontrolsettings.xml but it caused the GCS to fail during compile as there are of course other dependencies and iBus wasn't defined elsewhere as an RssiType

from dronin.

Ahh, it probably needs added to a switch statement or two in GCS. I'll take a look tonight.

from dronin.

Does this patch do the job?

diff --git a/ground/gcs/src/plugins/config/inputchannelform.cpp b/ground/gcs/src/plugins/config/inputchannelform.cpp
index 47c4785d2..c7eaca8c4 100644
--- a/ground/gcs/src/plugins/config/inputchannelform.cpp
+++ b/ground/gcs/src/plugins/config/inputchannelform.cpp
@@ -210,6 +210,9 @@ void inputChannelForm::groupUpdated()
         case ManualControlSettings::RSSITYPE_TBSCROSSFIRE:
             count = 12;
             break;
+        case ManualControlSettings::RSSITYPE_IBUS:
+            count = 10;
+            break;
         case ManualControlSettings::RSSITYPE_NONE:
             count = 0;
             break;
diff --git a/shared/uavobjectdefinition/manualcontrolsettings.xml b/shared/uavobjectdefinition/manualcontrolsettings.xml
index 75bc2754f..9fa338b73 100644
--- a/shared/uavobjectdefinition/manualcontrolsettings.xml
+++ b/shared/uavobjectdefinition/manualcontrolsettings.xml
@@ -46,6 +46,7 @@
         <option>OpenLRS</option>
         <option>FrSkyPWM</option>
         <option>TBS Crossfire</option>
+        <option>IBus</option>
       </options>
     </field>
     <field defaultvalue="0" elements="1" name="RssiChannelNumber" type="uint8" units="channel">

I suspect there is still something to be done on the flight side too.

from dronin.

from dronin.

That's correct. You'll need to add a case here first, at a minimum:

from dronin.

Success! I've added the relevant information where you suggested and a new case for ibus in dRonin/flight/Modules/ManualControl/transmitter_control.c and we are in business. Do you have the time to create a PR or should I have a go?

from dronin.

Great work. Have a go! 😁 GitHub docs: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

from dronin.

Thanks for all your help. I may be suggesting a few other minor changes for consideration in the near future as I've been playing with CharacterOSD.
So far I've managed to work out how to call the temperature data from barometer (someone wrote placeholder for Temp but it displayed nothing), shift some formatting about, cheer up the boot screen a little with some simple personalisation, and add a new average cell voltage option because I find it so much easier to compare voltage sag between 4/5/6s batteries that way :)

I may start on the fork tomorrow if I get a moment to stop!
Cheers again

from dronin.

More people flying dR and flaunting the LQG mode. Pressure to finally implement the ESC autotelemetry for torque is rising.

from dronin.