`commands` function returning a promise about cytoscape.js-cxtmenu HOT 3 CLOSED

@maxkfranz What do you think about the commands function returning a promise?

Alternative: manipulate the commands dynamically while the menu is open, e.g. disabling a command.

from cytoscape.js-cxtmenu.

Personally, I don't think it would work well unless you show the intermediate loading state somehow. Waiting for a potentially long async op to complete to show anything, like the menu, could give bad ux.

Your idea could be implemented by adding menu.disable(), menu.enable(), and menu.updateCommands() etc. to the returned menu object -- rather than introducing async directly to the extension.

Anyway, it's an interesting idea but it's not something that I have time to implement myself any time soon.

from cytoscape.js-cxtmenu.

I plan to provide a pull request realizing the promise approach very soon. It will be fully compatible with current API and will have no performance impact.

Async does not necessarily imply a long operation (no server request might be involved at all) and bad ux. The app developer is still free to provide a load indicator if due.

From my perspective the other approach -- extending the API -- would be both harder to implement in the extension, and harder to use by the app developer (as she must relate the async response to an open menu somehow).

from cytoscape.js-cxtmenu.