Git Product home page Git Product logo

Comments (7)

MikeMcC399 avatar MikeMcC399 commented on September 7, 2024

@irbrad

Could you please post your workflow?

from github-action.

irbrad avatar irbrad commented on September 7, 2024

Could you please post your workflow?

The Cypress portion of the workflow is as follows. This area of the workflow does have continue-on-error enabled. new_desktop_run_tests is generated with a bash step that searches for specific tags in the specs using cypress-grep. The action step isn't necessarily blocking deployments but it appears like it is. These are new tests that we are inserting into our CI process that need to be proved out before we move them into a position that they can block the deployment pipeline.

      - name: ${{ 'test pr-${{ github.event.number }} ${{needs.prep.outputs.short_sha}}' }}
        uses: cypress-io/github-action@v6
        with:
          working-directory: ./test
          browser: chrome
          record: ${{ inputs.record }}
          parallel: true
          install: false
          runTests: ${{ needs.prep.outputs.new_desktop_run_tests }}
          group: "Integration - Chrome - Desktop"
          spec: ${{ needs.prep.outputs.new_desktop_files }}
          config: '{"e2e": { "excludeSpecPattern": "cypress/integration/**/*.skip-ci.spec.js" } }'
          tag: ${{ inputs.cypress-cloud-base-tag }}
          ci-build-id: "${{ inputs.ci-build-id }}-new"
          publish-summary: false

from github-action.

MikeMcC399 avatar MikeMcC399 commented on September 7, 2024

@irbrad

Please refer to the GitHub Actions documentation steps context together with jobs.<job_id>.steps[*].continue-on-error

When a continue-on-error step fails, the outcome is failure, but the final conclusion is success.

This is standard functionality of the GitHub runner and you should be able to use this to meet your requirements.

You can also use if: ${{ always() }} to execute a step even if the previous step failed.

from github-action.

irbrad avatar irbrad commented on September 7, 2024

@MikeMcC399 Thanks for the response!

That's actually how I'm already running (both continue-on-error and always()) it but because the action throws a failure even though it continues it's still not lighting up the merge button on PR's even though it's actually functional. It's more confusing than anything else. Is there a way to force Cypress to not error out in the log file so that the action finishes cleanly (so green checkmark) even though the tests might have failed?

from github-action.

MikeMcC399 avatar MikeMcC399 commented on September 7, 2024

@irbrad

Could you please provide some screenshots to illustrate what checkmarks you are referring to? Is your repo public or private?

from github-action.

MikeMcC399 avatar MikeMcC399 commented on September 7, 2024

@irbrad

I'm wondering if your problem is with the Cypress Cloud GitHub Integration. Screenshots would help to clarify.

Note that Cypress Cloud support is available through https://www.cypress.io/support

from github-action.

MikeMcC399 avatar MikeMcC399 commented on September 7, 2024

Closing as there is not enough information to diagnose the issue and there hasn't been any further information supplied.

from github-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.