Add workspace support for pnpm about github-action HOT 10 OPEN

@osmestad

• You've tagged your problem here on to the feature request which is not so good for tracking and resolution of your individual issue.
• Please open a new issue to follow on from the issue #1138. I see this is the same repository https://github.com/tidal-music/tidal-sdk-web that was previously causing issues with pnpm and the Cypress GitHub action.

from github-action.

@osmestad

Good you found your problem!

I don't have privileges to delete other people's posts. You can however delete your own posts or select Hide from the three-dot menu and hide your post(s) from being displayed.

from github-action.

got it. I will keep an eye on it and if it reproduces again will create new issue with reproduction

from github-action.

Hey, we are trying to update Cypress and have gotten in a broken state again (like #1138 I think).

If I try to run a 'install only' in the repo root folder it seems to fail with this:

/opt/hostedtoolcache/node/20.12.2/x64/bin/npx cypress cache list
sh: 1: cypress: not found
Error: The process '/opt/hostedtoolcache/node/20.12.2/x64/bin/npx' failed with exit code 127

(https://github.com/tidal-music/tidal-sdk-web/actions/runs/8703877596/job/23871336933?pr=107#step:6:311)

If ran from the package with Cypress in it, it fails with this (expected I guess):

Action failed. Missing package manager lockfile. Expecting one of package-lock.json (npm), pnpm-lock.yaml (pnpm) or yarn.lock (yarn) in working-directory /home/runner/work/tidal-sdk-web/tidal-sdk-web/packages/player

(https://github.com/tidal-music/tidal-sdk-web/actions/runs/8702900798/job/23867967977#step:6:13)

Any clue what might cause this? I tried to delete the relevant cache and rerun but got the same results.

from github-action.

Sorry for that, feel free to delete my comments here if you like!
As for the issue, I think I found the problem, we did the caching in a previous step, and the name of the cache was too generic so the post-install trigger did not run. Sorry for the noise!

from github-action.

hello, I've just noticed one more problem with pnpm workspace. After latest release of action it shows that there is cypress '13.9.0' cached but later it fails to find binaries for '13.8.1' as our tests use it. I followed start-and-pnpm-workspaces and it worked like a charm until today )

Seems a bit similar to #971

Thank you 🙇🏻

from github-action.

@misha-erm

Please open a new issue if you are asking for help. This issue is for the pnpm workspace support enhancement request, not any bug reports about the existing implementation or documentation.

from github-action.

I added a comment there as I thought that might be in scope of "workspace support"
If you think that's not related, I can move it to separate issue, sure

if you are asking for help

For now I just upgraded local cypress version to match the version installed by the github action. Just was a bit surprised that action can't read correct version from pnpm-lock

from github-action.

@misha-erm

I tested start-and-pnpm-workspaces with Cypress 13.8.0 in workspace-1 and 13.9.0 in workspace-2 using the workflow example-start-and-pnpm-workspaces.yml and it worked correctly, installing and caching both versions.

If you need to have mixed Cypress versions in your pnpm workspaces and it is not working for you, then we can look at it in a separate issue. We would need to see your workflow and your lock file for that.

from github-action.

@misha-erm

• I found that the caching for pnpm (without workspaces) can be unreliable and I logged issue #1179 for that problem. I plan to investigate it further.
• Edit: see now PR #1180

from github-action.