Comments (1)
I think we can simplify this a little - copying what @cypress/request does may not be the best course.
cypress/request connection timeouts have a maximum of the OS-wide TCP connection timeout. Increasing this won't have any effect, and reducing this would probably only cause a higher error rate. I'd prefer to keep this at the OS-specified value; extending @packages/network Agent will be expensive to implement, and likely won't have a high rate of return.
Status code available sent is only important in error cases I think, which will simply reject the promise.
Data flowing is a great metric for timing out an upload, because it's what's important to the success of the upload.
I suggest:
- Timeout on "Upload Begin": the interval between
fetch
being called and the first .write to an intermediate .pipe from the artifact's ReadableStream. This handles: socket connect, http status/headers available (if sent prior to upload beginning). This is to detect initial connection errors. - Timeout on "Upload Progress": the time between each .write to an intermediate .pipe from the artifact's ReadableStream. This is to detect stalled uploads.
- No timeout on upload complete: the upload duration is too variable to choose a good number, and the error case (a stalled upload) is already handled by the progress timeout.
What do you think?
from cypress.
Related Issues (20)
- Can not open cypress due to this error "Circular symlink detected: "C:\Users\lmmki\AppData\Local\Application Data" points to "C:\Users\lmmki\AppData\Local" Error: Circular symlink detected: "C:\Users\lmmki\AppData\Local\Application Data" points to "C:\Users\lmmki\AppData\Local" at E._getEntryType (<embedded>:3864:7466) at async E._read (<embedded>:3864:6206)" HOT 1
- Understand/fix any implications of `unload` event deprecation within Chrome HOT 1
- Add option for Component Testing to JIT compile test before executing.
- Using Cypress.IO to to setData on CKeditor 4
- Override downloadsFolder configuration HOT 2
- Keep "specs list tree" state (scroll position, open / closed folders, ...) HOT 2
- cypress can't find chrome in v13.7.2 HOT 2
- Crash on Ubuntu 22.04 LTS HOT 2
- Setting input signals with Angular component tests not supported HOT 10
- cy.clearAllCookies() does not clear partitioned cookies in Chrome 123 HOT 1
- Seeing (page load)--waiting for new page to load-- for NodeJS made web app
- Can't install NPM package due to connection discrimination, 403 response HOT 1
- __cypress.initial cookie expired date causing signin side-effects HOT 2
- Angular Component Testing: signal-based input aliasing not supported HOT 1
- Cypress Crash on macOS Ventura - The Test Runner unexpectedly exited via a exit event with signal SIGABRT HOT 1
- Cypress doesn't like CSS zoom HOT 1
- Not able to generate code coverage report on running vue 3 (typescript) application on a headless mode HOT 1
- Tests fail with "ResizeObserver loop completed with undelivered notifications"
- chromeWebSecurity: false, // Disable web security to allow microphone access is not working in "cypress": "^13.6.2", I downgrade to 12.0.0 and it works fine
- Enormous amount of data getting stored in EC2 under .config/Cypress/cy/production/projects HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cypress.