Git Product home page Git Product logo

Comments (1)

cacieprins avatar cacieprins commented on June 9, 2024

I think we can simplify this a little - copying what @cypress/request does may not be the best course.

cypress/request connection timeouts have a maximum of the OS-wide TCP connection timeout. Increasing this won't have any effect, and reducing this would probably only cause a higher error rate. I'd prefer to keep this at the OS-specified value; extending @packages/network Agent will be expensive to implement, and likely won't have a high rate of return.

Status code available sent is only important in error cases I think, which will simply reject the promise.

Data flowing is a great metric for timing out an upload, because it's what's important to the success of the upload.

I suggest:

  • Timeout on "Upload Begin": the interval between fetch being called and the first .write to an intermediate .pipe from the artifact's ReadableStream. This handles: socket connect, http status/headers available (if sent prior to upload beginning). This is to detect initial connection errors.
  • Timeout on "Upload Progress": the time between each .write to an intermediate .pipe from the artifact's ReadableStream. This is to detect stalled uploads.
  • No timeout on upload complete: the upload duration is too variable to choose a good number, and the error case (a stalled upload) is already handled by the progress timeout.

What do you think?

from cypress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.