resolvers: reduce the impact of to_snake_case about cylc-flow HOT 2 OPEN

to_snake_case gets called on every field, it essentially translates between python variable names and JS names (i.e. taskProxy -> task_proxy).. only way to get rid of it would be to change the data-store to use JS names, but there may still be some translation kicked to somewhere .. But could be done (I think).

Would have to be a 8.x.0 release, as changing the protobuf var names will break the api.

from cylc-flow.

only way to get rid of it would be to change the data-store to use JS names

The to_snake_case command is being called many, many more times than we have field names to resolve.

This suggests that it is being called for the same field names over and over again, which from a skim of the code makes sense. So we don't need to "get rid" of this, only avoid duplicate calls. The best way to achieve this is to avoid the situation with a code refactor. The easiest way to avoid this is to wrap the to_snake_case function with functools.lru_cache.

from cylc-flow.