Git Product home page Git Product logo

Comments (5)

HilaryN avatar HilaryN commented on September 25, 2024

(I'm doing a fix alongside #497 )

from android.

HilaryN avatar HilaryN commented on September 25, 2024

I've created a new image from the old one and I've fudged this to make all the itinerary steps show as walking, just to get an idea of how the footprints would look with different types of arrow:

Screenshot_1662128482

from android.

mvl22 avatar mvl22 commented on September 25, 2024

I would strongly recommend not having different footprint positioning depending on the arrow. Visually this breaks standard design rules about consistency.

Basically just pick a location, e.g. bottom right of the square, and stick to it. If you set it to overlay the arrow with a higher z-index then it will always show and not be lost. Consider putting a white circle around the feet so that it is always visually separate over the arrow as a small blob.

from android.

HilaryN avatar HilaryN commented on September 25, 2024

The positioning here is the same for all the arrows - I just wanted to see how it would actually look with different arrows.

from android.

oliverlockwood avatar oliverlockwood commented on September 25, 2024

The positioning here is the same for all the arrows - I just wanted to see how it would actually look with different arrows.

What I notice upon close inspection, is that the arrows have a clear background, and then the footprints have a white background.
This becomes obvious in the entries in the instructions which spill onto a second line.

In my opinion:

  1. if there is to be a background, this should be part of the layout such that it is either there or not there, consistently for the whole relevant image area, regardless of whether there are footprints, and regardless of the length of the instruction line.
  2. Both the arrow (as currently) and footprint images should have a clear background.
  3. We would benefit from @si-the-pie's vector image drawing skills to define a footprints icon SVG which we can then import into an Android vector icon (we did this before, for all the arrows, and it made things look a lot better).

from android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.