add `andFilterWhere` condition about orm HOT 3 CLOSED

You can do this with custom repositories

use Cycle\ORM\Select\Repository;

class UserRepository extends Repository
{

    public function withFilterWhere($column, $operator, $value)
    {
        $r = $this;
        if ($value !== null) {

            $r = clone $this;
            $r->select->where($column, $operator, $value);
        }

        return $r;
    }
}

Sample usage

$code = 1;
$name = 'cat';

/** @var UserRepository $repo */
$repo = $this->orm->getRepository(User::class);

$users = $repo
    ->withFilterWhere('code', 'like', $code)
    ->withFilterWhere('name', 'like', $name)
    ->findAll();

https://github.com/cycle/docs/blob/master/basic/repository.md
https://github.com/cycle/docs/blob/master/advanced/chained-repository.md

from orm.

Hi @albertborsos

I'm against adding this feature for 3 main reasons:

1. The method is confusing, should it skip condition when the value is null/false/empty string?
2. We are saving 2 lines of code but introducing a new concept of optional conditions, this will make code maintenance harder down the road.
3. As @genhoi it's much easier to add custom filter logic to repositories (which they are intended for).

Thanks for your suggestion, I'm open to change my opinion if more arguments will surface, this ticket will remain open for the discussion for the next few months.

from orm.

Thanks! This solution is good enough for me.

from orm.