What Using <a href="https://kubernetes.io/docs/reference/using-api

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Controller should set a proper field manager about accurate HOT 4 CLOSED

erikgb commented on July 3, 2024

Controller should set a proper field manager

from accurate.

Comments (4)

ymmt2005 commented on July 3, 2024 1

Accurate does not use server-side apply yet.
operation: Update indicates that the change was made by normal Update operation rather than SSA.

It might be better to set an appropriate FieldManager, but not setting it is not a bug as we are not using SSA.

from accurate.

erikgb commented on July 3, 2024 1

@ymmt2005 Nice find! So we (unintentionally) fixed this in #88. 😄

from accurate.

zeroalphat commented on July 3, 2024

@erikgb
As your feedback, it looks like it should be fixed.
We will fix it.

from accurate.

ymmt2005 commented on July 3, 2024

Figured out that setting Go-http-client was actually a regression of controller-runtime.
kubernetes-sigs/controller-runtime#2435

This is fixed in controller-runtime v0.16, so Accurate will set the field manager to
accurate-controller with the next release.

I checked the current code and saw:

$ kubectl -n sub1 get secrets -o yaml --show-managed-fields
apiVersion: v1
items:
- apiVersion: v1
  data:
    foo: YmFy
  kind: Secret
  metadata:
    annotations:
      accurate.cybozu.com/from: root1
      accurate.cybozu.com/propagate: update
    creationTimestamp: "2023-09-27T13:47:06Z"
    labels:
      app.kubernetes.io/created-by: accurate
    managedFields:
    - apiVersion: v1
      fieldsType: FieldsV1
      fieldsV1:
        f:data:
          .: {}
          f:foo: {}
        f:metadata:
          f:annotations:
            .: {}
            f:accurate.cybozu.com/from: {}
            f:accurate.cybozu.com/propagate: {}
          f:labels:
            .: {}
            f:app.kubernetes.io/created-by: {}
        f:type: {}
      manager: accurate-controller
      operation: Update
      time: "2023-09-27T13:47:06Z"