Comments (3)
Thank you for this update :)
Can you please check now ?
I added check to see if cgroup
exist.
I am not familiar with container without it, but if there are, we can add more checks to see if this is a container.
from kubiscan.
Closing this since it works, thanks :).
from kubiscan.
Yes, the d4471d1 works. I think a "cleaner solution" would be to explicitly check for the operating system and don't call the running_in_docker_container
in case when it is other than Linux? This could be done e.g. via:
import platform
# interestingly its docstring says:
# Returns the system/OS name, e.g. 'Linux', 'Windows' or 'Java'.
# but it returns 'Darwin' for MacOS
os = platform.system().lower()
if os == 'linux' and running_in_docker_container():
# ...
But I am completely fine with the current solution too.
I am not familiar with container without it, but if there are, we can add more checks to see if this is a container.
There are no native containers on MacOS and the Docker for Mac just uses a linux VM under the hood (see e.g. https://docs.docker.com/docker-for-mac/install/). Also, I don't think people run containers with e.g. procfs mounted in a different path or without cgroups. Though, we may see containers being based on cgroups v2 (which maybe produces different output of /proc/self/cgroup
? not sure here).
from kubiscan.
Related Issues (20)
- Is this a fork or the original kubiscan? HOT 1
- ConnectionRefusedError: [Errno 61] Connection refused HOT 1
- Linux Package of the tool (FR) HOT 1
- Static Scan HOT 2
- Add "nodes/proxy" as a risky permission HOT 4
- 'docker_run.sh' script returning permission denied error when trying to copy into the container HOT 1
- Provide more info how run `KubiScan`on EKS cluster HOT 2
- Duplicated service account name in -rp command HOT 1
- Privacy Declaration? HOT 2
- Dependecy issue in the Dockerfile in pip requirements. Can't build the docker image. HOT 4
- Support for kubeconfig credentials directly in kubeconfig file HOT 1
- Issue in /KubiScan/engine/jwt_token.py HOT 16
- Enhancements for output HOT 2
- Failed chmod when not specifying AWS info HOT 1
- setup file HOT 3
- cannot run KubiScan HOT 2
- anonymous permissions HOT 5
- JSON output failure HOT 2
- "patch" workloads not considered risky?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubiscan.