Comments (14)
Special thanks to @philwade for the fix and thanks to the rest of you for help testing and stuff!
from hyperterm-visor.
From my experience, hyperterm-summon
does not suffer from this issue. I know it utilizes hyperterm-register-shortcut
(a library created by the same author).
It may be worth exploring using hyperterm-register-shortcut
for hyperterm-visor
or, at the very least, comparing the approaches used to bind the global shortcut.
Hope this helps some.
from hyperterm-visor.
Just to see if it will resolve the issues, I implemented hyperterm-register-shortcut on this branch: https://github.com/philwade/hyperterm-visor/tree/try-hyperterm-register-shortcut
It would still need cleanup to get released, but if some people experiencing this issue could test and see if it fixes things, that would be handy.
Note: This branch requires you to add a different config setting for the hotkey
config: {
hotkeys: {
hotkey: 'CommandOrControl+Z',
}
}
from hyperterm-visor.
@RTSchriner cool, I haven't either, going to test it out again for the rest of today and if everything looks good I'll clean it up and put together a PR
You were able to figure out the new config setting even though I failed to put it my original comment?
from hyperterm-visor.
I was wondering if I was the only one! Is this something fixable by the author or something we'd be able to test/fix in the community?
from hyperterm-visor.
Is there a way you can more consistently reproduce this? I tried shutting my laptop for a while and opening it back up, and I also tried Apple Menu > Sleep, but the hotkey was working after both of those.
I have seen this very occasionally, so I do think something fishy is going on, but it doesn't appear to be triggered by sleep (or at least not by only going to sleep...).
Either way, finding a consistent cause will definitely help in debugging.
from hyperterm-visor.
I've been seeing this about once a day during my work day, so far have been unable to figure out a consistent way to reproduce. Seems to happen after being idle as well.
I left open developer tools to try and catch something when it happens, no errors or anything
from hyperterm-visor.
I've noticed the same issue. I can't quite pinpoint what it is, but the hotkey definitely stops working for me every so often.
from hyperterm-visor.
it looks like hyperterm-register-shortcut uses the same mechanism, namely:
const { globalShortcut } = require('electron');
Although it is called a little different:
https://github.com/soutar/hyperterm-register-shortcut/blob/master/index.js#L10
vs
https://github.com/CWSpear/hyperterm-visor/blob/master/visor.js#L34
from hyperterm-visor.
@philwade: Testing it now! I'll let you know if I continue to have issues. Thanks for your work!
from hyperterm-visor.
@philwade: I haven't had any issues yet. Seems to be working.
from hyperterm-visor.
@philwade Hmmmm... config setting!?
Note: Your fix is still working great! Great work!
from hyperterm-visor.
The people in this thread has been especially helpful... think I could get your help with a non-sleep issue?
Need help testing the new anchor
(replaces position
) option in the forthcoming 1.0: #5 (comment)
from hyperterm-visor.
I can confirm it is still happening (as has been since the beginning). The scenario is simple, after the day I drag the mouse to activate one of the hotcorners on my screen to put display to sleep. Next morning the visor's shortcut does not work any more, I have to restart Hyper, then all is ok again. Visor always works until I put display to sleep, after that Hyper's restart is needed.
from hyperterm-visor.
Related Issues (20)
- Do not move from current workspace when showing opened hyperterm HOT 2
- Visor shortcut doesn't cause hyperterm to appear HOT 2
- Stay on same screen HOT 1
- Does not work at all HOT 7
- Fullscreen uses only a portion of the vertical space HOT 2
- Has this been tested on more recent versions? HOT 3
- ยง key binding not working / Invalid key binding removes all key bindings from hyperterm HOT 1
- Opens and closes once, then de-focusses and stops HOT 3
- Multi monitor support HOT 2
- Height setting doesn't update? HOT 1
- Not working HOT 3
- Return focus to prev active window HOT 1
- hot key stopped working. HOT 2
- hotkey not working anymore, instead it creates a new hyperterm window HOT 3
- Does not work in Hyper 2.0.4 HOT 2
- Does not work in Hyper 1.4.8 HOT 2
- Is this plugin still active ? HOT 2
- Make window take 100% of available height. HOT 1
- Error updating plugins HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyperterm-visor.