Where to destroy the database connection about sqldatasource HOT 4 CLOSED

Do you not use a database with pooling? Managing your own connections is usually not recommended. You can configure pooling in the knex config object.

from sqldatasource.

Also it looks like you are using an older version of this lib. In v1 the format is different which may explain it not connecting. Check out the readme for more information!

from sqldatasource.

I'm using this with oracledb and it looks like the pool connection keeps the event loop busy and so the process does not exit.
I'm especially concern about this as I will be executing within an AWS lambda.
After discussing with the guys behind oracledb module, I was suggested to close the pool when the SIGTERM/SIGINT signals are issued.

I do this where I create the datasources.

const Clients = require("./clients");
const OracleAnalytics = require("./oracle-analytics");

const Oracle = new OracleAnalytics();

const dataSources = () => ({
  clients: new Clients(),
  oracleAnalytics: Oracle
});

module.exports = dataSources;

async function closePoolAndExit() {
  try {
    await Oracle.db.destroy();
    console.log("Pool closed");
    process.exit(0);
  } catch (err) {
    console.error(err.message);
    process.exit(1);
  }
}

process.once("SIGTERM", closePoolAndExit).once("SIGINT", closePoolAndExit);

Here is the thread about oracledb Github Thread

from sqldatasource.

Note, please use the KNEX documentation for pooling, this is merely a thin wrapper on top of KNEX.

from sqldatasource.