Comments (4)
Just feels a bit invasive. I don't have them installed locally so was surprised when I couldn't commit something and couldn't figure out why. Turned out it was because I had tested out the flake PR
For me, setting up the flake shouldn't have any impact on non-flake setup. I had thought isolation was one of the goals
from cursorless.
It's not required no. Since it's a development shell, and I assume people using it would be committing things, it made sense to install the hooks? I don't mind removing it, but also curious why you think it's bad? Does it clobber existing tools if you already had them and then test the dev shell or something?
Lots of flakes do it afaik, but also would be ok to just print a message in the shellHook saying it pre-commit install can be run if needed?
from cursorless.
Ah interesting, that makes sense. Bad assumption on my part. I'll send a PR to remove it.
Why don't you use pre-commit locally out of curiosity. I specifically wonder about cases where it would catch stuff that can't be auto fixed by running it in CI?
from cursorless.
I prefer my git commit to be dumb, fast, and predictable. It's plumbing
from cursorless.
Related Issues (20)
- Trigger symbol highlight on selection change HOT 3
- Neovim: Await promises
- tutorial: Handle starting tutorial directly at step with no prerequisites
- docs: Detect broken links from docs to other places in repo
- Make it easier for users to see their alphabet
- Increase memory for test CI HOT 3
- remove lua-language-server PR patch overlay from flake when fixed
- Investigate DFA compilation times HOT 4
- pnpm install -F cursorless-vscode install-local is broken
- Enforce `type` in front of type-only imports HOT 1
- Docs reference deprecated left/right grammar for surrounding pairs HOT 1
- Special handling of previous/next scope when in a code block/body
- Error generated by cursorless-talon when switching to Vosk dictation HOT 2
- Migrate all relevant recorded tests to next-gen facet tests
- Pokey "return from leave" discussion list
- "Edit this page" docs link broken
- Tracker: unmitigated issues in tree-sitter-kotlin HOT 5
- Make cheat cheat more robust
- When you 'clone call' in javascript it results in a syntax error
- Support more granular comment target
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cursorless.