[Meta] Issues regarding master branch about currency-cop HOT 22 OPEN

soo how to get the new version then?

from currency-cop.

@Smeagol001 check the "if you want to beta test" section of the post

from currency-cop.

how to do that with windows? im kind of a noob in regards to github^^

from currency-cop.

@Smeagol001 You have to install git and nodejs. Clone the project via git, open cmd in the project folder and run the commands above.

from currency-cop.

Commands are kinda wrong, though)

Clone the repository
npm run install
npm start

There is no such commands in package.json, you should probably run just npm install and then npm run dev. But I have troubles after that

Uncaught error: AccountActions.render(): A valid React element (or null) must be returned. You may have returned undefined, an array or some other invalid object. - Invariant Violation: AccountActions.render(): A valid React element (or null) must be returned. You may have returned undefined, an array or some other invalid object.

More errors after that

from currency-cop.

Must be on the right branch

from currency-cop.

I am on the right branch :) feat/remove-material-ui. You can double check, but there is no such commands as npm run install and npm start

from currency-cop.

@O4epegb apologies, I haven't ever logged out, just saw the error you were running into. I thought you were encountering this on the build phase.

Pushing out an update:

https://github.com/currency-cop/currency-cop/releases/tag/2.0.0-beta.2

from currency-cop.

Yep, it works now!

But now I have errors after generating porfolio and trying to select it :)

[11:52:15] [CRITICAL] [Core] Uncaught error: Cannot read property 'items' of null - TypeError: Cannot read property 'items' of null at AppPortfolio.render (http://localhost:8080/bundle.js:59270:53) at http://localhost:8080/bundle.js:36722:21 at measureLifeCyclePerf (http://localhost:8080/bundle.js:36002:12) at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (http://localhost:8080/bundle.js:36721:25) at ReactCompositeComponentWrapper._renderValidatedComponent (http://localhost:8080/bundle.js:36748:32) at ReactCompositeComponentWrapper.performInitialMount (http://localhost:8080/bundle.js:36288:30) at ReactCompositeComponentWrapper.mountComponent (http://localhost:8080/bundle.js:36184:21) at Object.mountComponent (http://localhost:8080/bundle.js:6772:35) at Object.updateChildren (http://localhost:8080/bundle.js:35855:51) at ReactDOMComponent._reconcilerUpdateChildren (http://localhost:8080/bundle.js:40637:32)

EDIT: But after app reload it is now fine, I was able to select portfolio, so you need to check why it might crash right after generating first portfolio maybe

from currency-cop.

@O4epegb Resolved in 2.0.0-beta.3

from currency-cop.

New release button definitely works 😀

from currency-cop.

"Houston we have a problem" when starting CC while logged in (logging out and in results in the same thing). Any log files I can peek at for a more helpful error?

from currency-cop.

Check under %appdata%/currency-cop

from currency-cop.

2.0.0-beta.5 released 🎉

from currency-cop.

I tested the latest beta and it's really buggy. I created one portfolio for Bestiary and Standard and they worked, but then I created one for Flashback and but somehow it became Bestiary as well and I had 2 Bestiary portfolio. I couldn't delete one of them so I tried to change the league and everything seemed to break, items on different league got merged together. Sometimes opening the app would get it stuck on Gathering prices and tabs.

from currency-cop.

Thank you for testing and the feedback!

If it gets stuck on the prices & tabs that means its still fetching, the poe api takes a while sometimes.

Will look into your first issue

from currency-cop.

@chinhodado in the next release there will be text next to the Gather prices and tabs indicating which one it is fetching. Maybe this will give you a feeling of advancement :)

from currency-cop.

2.0.0-beta.7 released 🎉

• Sorting
• Individual Price
• Better Messaging
• 5L / 6L reporting works
• ...and more!

from currency-cop.

Can you make fetching prices running in the background when first opening the app? Right now on start up it's fetching currency and item prices for 6 leagues for like 30 seconds when most people are only interested in a league or two, not to mention some don't care about items and only care about pure currency, etc. It makes more sense to show the portfolio right away, then update the portfolio's worth as prices are coming back.

from currency-cop.

@chinhodado Fetching starts immediately to ensure that leagues are setup prior to entering the application to ensure that the creation screen is fully functional, do you stop and start the application frequently? This could cause your account to be rate limited as there is no control mechanism for this type of action.

from currency-cop.

The portfolio creation is only dependent on the list of league and list of tabs for each league right? All other info are not needed to create a portfolio, only to update its worth. This also ensure that you don't have to fetch prices for leagues that you don't care about. So in short

• When the app is first started, fetch prices only for leagues that have at least one portfolio created. If no portfolio is created, don't fetch anything. Fetch in the background and possibly display a progress bar but don't block the UI.

• After a portfolio is created, add the portfolio's league to the list of league to fetch price for

from currency-cop.

2.0.0-beta.8 released 🎉

• Added delete button 🎉
• Datafile writes are now debounced, improves i/o usage.
• Fixes price issue with Tabula Rasa, and other items that have links = 0.
• Fixed issue where price changes had no colors
• Fixed sorting by price in portfolio view
• Fixed issue where users could not view, edit, or modify syncing tabs
• Fixed issue with old league tabs not being able to update settings due to missing tabs
• Fixed issue where item images no longer report relic status, relics are now properly matched

from currency-cop.