RelativeTimeTextView and memory leaks about android-ago HOT 6 CLOSED

Thanks for this report. I'll take a look.

from android-ago.

Hi,

Did you managed to fix this?

from android-ago.

Hi @Winghin2517 I'm sorry I haven't had a chance to look at it yet. The problem seems to be that the UpdateTimeRunnable holds a reference to the View and hence to the Activity. I'm not sure if using an Application Context is the right way to fix it. Instead, I should be attaching and detaching the runnable in the appropriate callback methods.

from android-ago.

Actually, I'm not sure about the point of this library - you actually don't need this library to tell relative time. Java already does it natively by using the method:http://stackoverflow.com/questions/25174921/time-ago-for-android-java

DateUtils.getRelativeTimeSpanString(long time, long now, long minResolution)

Best to use this method as this library is leaking.

from android-ago.

@Winghin2517 This library internally uses the DateUtils class that you mentioned. The README explains this clearly. But the reason to use this library is to automatically call the DateUtils method when the time changes.

For example,

• suppose it is 10:05 am now. You set the relative time to 10:00 am. So, it shows "5 minutes ago".
• After a minute, it becomes 10:06 am. But if you use regular DateUtils, you will still be showing "5 minutes ago", which is wrong. It should slow "6 minutes ago".

This library uses a Handler to automatically update the TextView whenever required so that the relative time displayed is always correct.

As to the memory leak, I haven't got time to fix it but contributions are appreciated!

from android-ago.

Fixed in v1.3.2. Uploaded to maven central. Will be available .. .eventually ... hopefully.

from android-ago.