Git Product home page Git Product logo

Comments (9)

mmontone avatar mmontone commented on July 17, 2024

I see the error. I'm having a look.

from erudite.

mmontone avatar mmontone commented on July 17, 2024

Yes, looks like a problem with MethodAdvisers.

from erudite.

mmontone avatar mmontone commented on July 17, 2024

I wonder about two things: how was this working before? Or was it?

And: I'm not sure how fixable this is. #perform: is implemented as a vm primitive, and I'm replacing the CompiledMethod entry by an AdvisedMethod entry, and looks like the replacement doesn't go unnoticed by the vm.

from erudite.

mmontone avatar mmontone commented on July 17, 2024

More precisely, error is: It is not possible to #peform: adivised methods. An 'Error: bad number of arguments' is signaled.

from erudite.

mmontone avatar mmontone commented on July 17, 2024

Tried making AdvisedMethod subclass of ProtoObject instead of Object. But same error. And other errors appear.

from erudite.

mmontone avatar mmontone commented on July 17, 2024

I've tested this in older images, and there are no problems there.

#peform: implementation looks like this in the image I've tested:

perform: arg1
<primitive: 83>
^ self
perform: arg1
withArguments: (Array new: 0).

from erudite.

mmontone avatar mmontone commented on July 17, 2024

Reverting the #perform: method to its previous implementation above solves this issue with AdvisedMethods.

from erudite.

mmontone avatar mmontone commented on July 17, 2024

This is fixed in Cuis-Smalltalk/Cuis-Smalltalk-Dev@c76613b

from erudite.

andswitch avatar andswitch commented on July 17, 2024

Amazing! Thank you so much for a very quick fix! 🚀

from erudite.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.