LOG* not colouring text about cuberite HOT 14 CLOSED

Lindows or Winux?

from cuberite.

The penguin :)

from cuberite.

I don't think I get colours either, so it isn't something to do with SSHing in. It's probably windows only colours or something.

from cuberite.

The coloring is currently implemented only on Windows. None of us know the dev details necessary to implement coloring on Linux; we definitely don't want to use a 3rd party library dependency for that.

from cuberite.

Hm. Colours will be -very- useful in distinguishing between normal information and errors. And xterm must support it because it works in other programs. I shall see!

Okay, bearbin doth see.

from cuberite.

Easy! - just need some platform detection stuff and dump in this:

http://stackoverflow.com/questions/2616906/how-do-i-output-coloured-text-to-a-linux-terminal

Of course, for the best practice, the terminfo database should be checked with the type of terminal to make sure it's colour capable.

from cuberite.

So dump it into cMCLogger::SetColor(), there's already the Win32 implementation. The function gets a single byte, the upper 4 bits specify the background color and the lower 4 bits the foreground color, based on the 16-color VGA-like palette.

from cuberite.

The code would have to be squished around, because the setcolour function cannot modify the text it is changing the colour of. Is this ok?

from cuberite.

It doesn't have to - just let that function output the coloring code to the console.
Just make the function not output anything if ANDROID_NDK is defined.

from cuberite.

so it would be ifndef ANDROID_NDK, and then ifdef LINUX or what?

from cuberite.

Let's hope I got the GFM right :)

#ifdef _WIN32
  // Current Windows-specific code
#elif !defined(ANDROID_NDK)
  // Linux-specific code
#end

from cuberite.

I don't think I'm able to do this - it would require refactoring of the code, and I don't think I'm good enough at C++ to do it.

from cuberite.

I can try, but I have no way of verifying if it works.

from cuberite.

Fixed.

from cuberite.