Comments (8)
@ctrlplusb The issue happens when you have multiple react components that are siblings, so if you updated your tree to be:
const tree = (
<OnlyChildren something={1}>
<OnlyChildren something={2}>
<div>Hello world!</div>
</OnlyChildren>
<OnlyChildren something={3}>
<div>Hello world!</div>
</OnlyChildren>
</OnlyChildren>
)
you would expect actual to be [1, 2, 3]
, when in fact the children are never visited, resulting in actual being only [1]
. See screenshot:
from react-tree-walker.
Hey @grxy
Awesome, thanks so much for picking this up. I'll try review and merge within the next 24 hours. 👍
from react-tree-walker.
@ctrlplusb No prob, dude. I actually noticed the issue when writing unit tests for my code while using this.
P.S. Great work breaking it out from react-apollo!
from react-tree-walker.
Hi @grxy 👋
Apologies for the late one on this.
I have struggled to recreate your initial issue. I have added another branch containing a test that I was initially expecting to fail as it doesn't have your fix applied. The test passes though.
Do you mind having a look to see if I have configured the test correctly?
Thanks!
from react-tree-walker.
Perfect thanks!
from react-tree-walker.
@ctrlplusb Any chance you'll be able to merge my PR and publish 2.1.2 soon?
from react-tree-walker.
All done and published. Thanks for being persistent with me!
from react-tree-walker.
@ctrlplusb Great! Thank you!
from react-tree-walker.
Related Issues (20)
- Support React v16.3 context API HOT 9
- Support preact HOT 1
- Support concurrent branch traversal HOT 2
- Behavior on server-side when using in conjunction with dynamic imports HOT 7
- Fails with CSS in JS systems HOT 2
- Problems with context using react-jss HOT 1
- Accept iterables and collections as children. HOT 1
- A promise was created in a handler at webpack-internal://...react-tree-walker... but was not returned HOT 2
- feature request: provide current element depth to visitor function HOT 1
- Add support for getDerivedStateFromProps
- Add a note that this is discouraged HOT 4
- React.forwardRef is not supported HOT 1
- fixing React.createContext in SSR HOT 18
- ReactDOMServer.renderToString() recreates components tree from the scratch HOT 1
- issue with connect, outdated props when rendered HOT 1
- React tree walker can not walk children 2.0.0 react-async-component components HOT 1
- Fix new Context handling (react@^16.6.x)
- Warning: Rendering <Context.Consumer.Provider> is not supported and will be removed in a future major release. HOT 3
- Type error in ssr development mode
- You should not use <Switch> outside a <Router> HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-tree-walker.